Skip to content

Download archive in pub_worker before the analysis begins (and work on the downloaded directory). #8173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2024
Merged

Download archive in pub_worker before the analysis begins (and work on the downloaded directory). #8173

merged 1 commit into from
Oct 30, 2024

Conversation

@isoos
Copy link
Collaborator

@isoos isoos commented Oct 21, 2024

@isoos isoos requested a review from jonasfj October 21, 2024 12:38
@isoos isoos marked this pull request as draft October 21, 2024 12:57
@isoos
Copy link
Collaborator Author

isoos commented Oct 21, 2024

Note: it seems that the inspectDir method will fail if the downloaded archive does not have a git repository. We'll need to update pana first to make this work, switching this to draft PR for the time being.

@isoos isoos mentioned this pull request Oct 21, 2024
Merged
@isoos isoos mentioned this pull request Oct 24, 2024
Merged
@isoos isoos marked this pull request as ready for review October 30, 2024 10:54
@isoos isoos force-pushed the worker-download branch 2 times, most recently from fa887ed to 3a7d31e Compare October 30, 2024 11:16
@isoos isoos merged commit 095aefb into dart-lang:master Oct 30, 2024
32 checks passed
@isoos isoos deleted the worker-download branch October 30, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonasfj jonasfj jonasfj approved these changes

@sigurdm sigurdm sigurdm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@isoos @jonasfj @sigurdm