Skip to content

Conversation

@isoos
Copy link
Collaborator

@isoos isoos commented Oct 21, 2024

No description provided.

@isoos isoos requested review from jonasfj and sigurdm October 21, 2024 15:22
Copy link
Contributor

@sigurdm sigurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a link to somewhere describing this issue?

@isoos
Copy link
Collaborator Author

isoos commented Oct 22, 2024

Do we have a link to somewhere describing this issue?

We have packages that depend on package:macros, but do not update their SDK constraint for it. Similar example is dartdoc, and the current plan is to just wait it out: dart-lang/dartdoc#3887

Because their SDK would allow the current stable, we are trying and failing analysis on that. I think it is better to give a temporary fix so that these packages do get analysis.

@sigurdm
Copy link
Contributor

sigurdm commented Oct 22, 2024

Thanks - it is nice to have the context written out when we revisit this in the future.

@isoos isoos merged commit 367e077 into dart-lang:master Oct 22, 2024
32 checks passed
@isoos isoos deleted the macros-analysis branch October 22, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants