Skip to content

Conversation

@isoos
Copy link
Collaborator

@isoos isoos commented Nov 5, 2024

  • Part of the split of Reduce the memory allocation during search with mutable IndexedScore. #8225
  • Fixed the Map<String, double> search(String text) method used by tests: previously it did not split the query text to multiple terms, only used the token matching to extract multiple tokens.
  • The change in term-weights calculation slightly changes the final score of multi-term hits, as the wordSizeExponent is not applied on the document weights inside the loop, and when we multiply the scores, this effect lowers their final score a bit.
  • However, the change is mostly a noise when it is observed outside of the narrow TokenIndex in the test, and should not change the rank order (for a specific query) much, as is shown in all the other tests that did not change, while they combine the name+description+readme token indexes.

@isoos isoos requested review from jonasfj and sigurdm November 5, 2024 14:07
@isoos isoos merged commit 12f2c66 into dart-lang:master Nov 5, 2024
32 checks passed
@isoos isoos deleted the search-docweight branch November 5, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants