Micro-optimizations of search score handling. #8230
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PackageNameIndex.search(used only in tests) is updated to update itsfilterOnPackagesset on subsequent iteration. If this would be used elsewhere, it would probably improve the search by reducing the number of ngram-similarity calculation done by the index.PackageNameIndex.searchWordis updated to not insert entries below the 0.5 score threshold (so we don't need to update the map to remove them later).PackageNameIndex.searchWordalso removed scores that were half of the largest score present, but in practice, with the combination of the 0.5 threshold (above) this does not have any further effect, as the maximum it would have removed would be 0.5 anyway. Removing that part is a no-op.TokenIndexconstructor spares us the internal lookup.