Skip to content

Write not-found.json to ExportedApi #8252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Write not-found.json to ExportedApi #8252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions app/lib/package/api_export/api_exporter.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,15 @@ class ApiExporter {

await synchronizePackageNameCompletionData();

await _api.notFound.write({
'error': {
'code': 'NotFound',
'message': 'Package or version requested could not be found.',
},
'code': 'NotFound',
'message': 'Package or version requested could not be found.',
});

await _api.garbageCollect(allPackageNames);
}

Expand Down
9 changes: 9 additions & 0 deletions app/lib/package/api_export/exported_api.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,15 @@ final class ExportedApi {
Duration(hours: 8),
);

/// Interface for writing `/api/not-found.json` which is what the bucket will
/// use as 404 response when serving a website.
ExportedJsonFile<Map<String, Object?>> get notFound =>
ExportedJsonFile<Map<String, Object?>>._(
this,
'/not-found.json',
Duration(minutes: 10),
);

/// Run garbage collection on the bucket.
///
/// This will remove all packages from `latest/` and `<runtimeVersion>/`,
Expand Down
Loading