Reuse IndexedScore instances, as emptying the values is faster than discarding and re-allocating memory. #8297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigurdm
reviewed
Nov 18, 2024
| score = IndexedScore<K>(_keys, value); | ||
| } | ||
| final r = fn(score); | ||
| _pool.add(score); |
Contributor
There was a problem hiding this comment.
This logic means that we will never have more scores then the high-watermark of scores that we need at one time - right?
Thus we don't really risk leaking excessive memory... right?
Collaborator
Author
There was a problem hiding this comment.
That's correct. We also replace the index every 15 minutes, and if there is an extreme outlier period, its memory footprint won't be around after that.
sigurdm
approved these changes
Nov 18, 2024
…iscarding and re-allocating memory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local benchmark showed about 5-6% difference on a continuous load.