Skip to content

Bump package:gcloud, make metadata updates non-critical #8298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Bump package:gcloud, make metadata updates non-critical #8298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b33a0e
Bump package:gcloud, make metadata updates non-critical
jonasfj Nov 18, 2024
e6abf00
Bump pubspec.lock
jonasfj Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions app/lib/package/api_export/exported_api.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -631,7 +631,14 @@ final class ExportedBlob extends ExportedObject {
// _retouchDeadline
final retouchDeadline = clock.agoBy(_updateValidatedAfter);
if (destinationInfo.metadata.validated.isBefore(retouchDeadline)) {
await _owner._bucket.updateMetadata(dst, _metadata());
try {
await _owner._bucket.updateMetadata(dst, _metadata());
} catch (e, st) {
// This shouldn't happen, but if a metadata update does fail, it's
// hardly the end of the world.
// We might detect stray files later as a result of this.
_log.warning('Failed to updateMetadata on "$dst" failed', e, st);
}
}
return;
}
Expand Down Expand Up @@ -659,7 +666,14 @@ extension on Bucket {
if (info.isSameContent(bytes)) {
if (info.metadata.validated
.isBefore(clock.agoBy(_updateValidatedAfter))) {
await updateMetadata(name, metadata);
try {
await updateMetadata(name, metadata);
} catch (e, st) {
// This shouldn't happen, but if a metadata update does fail, it's
// hardly the end of the world.
// We might detect stray files later as a result of this.
_log.warning('Failed to updateMetadata on "$name" failed', e, st);
}
}
return;
}
Expand Down
2 changes: 1 addition & 1 deletion app/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ dependencies:
fake_async: ^1.2.0
fake_gcloud:
path: ../pkg/fake_gcloud
gcloud: ^0.8.17
gcloud: ^0.8.18
googleapis: ^13.0.0
googleapis_auth: ^1.1.0
html: ^0.15.0
Expand Down
2 changes: 1 addition & 1 deletion pkg/fake_gcloud/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ environment:
resolution: workspace

dependencies:
gcloud: ^0.8.17
gcloud: ^0.8.18
logging: '>=0.11.3 <2.0.0'
clock: ^1.1.0

Expand Down
4 changes: 2 additions & 2 deletions pubspec.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,10 +314,10 @@ packages:
dependency: transitive
description:
name: gcloud
sha256: "4023f8f3dde8324ca8d17bd419767986764ac90a1173b207d4bc0e1784e9095f"
sha256: c63576bbd60b7dccd1548d51286e1c5b82e26b62440372a09c2aad0785d2e9f4
url: "https://pub.dev"
source: hosted
version: "0.8.17"
version: "0.8.18"
glob:
dependency: transitive
description:
Expand Down
Loading