Skip to content

Conversation

@isoos
Copy link
Collaborator

@isoos isoos commented Nov 19, 2024

@isoos isoos requested review from jonasfj and sigurdm November 19, 2024 16:38
@isoos
Copy link
Collaborator Author

isoos commented Nov 19, 2024

I've started to push this to staging for better testability.

@sigurdm
Copy link
Contributor

sigurdm commented Nov 21, 2024

I think the general advice is to not use drop-shadows in dark mode at all.

See https://medium.com/@tundehercules/designing-effective-dark-mode-interfaces-17f38ecea2e9#:~:text=Shadows%20%2CElevation%20and%20Depth

@isoos
Copy link
Collaborator Author

isoos commented Nov 21, 2024

I was planning to keep the two themes conceptually the same, but the argument for not using shadows entirely is a good one. I'll review the other parts of the article and redo this afterwards.

@isoos isoos closed this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants