Skip to content

Conversation

@isoos
Copy link
Collaborator

@isoos isoos commented Nov 20, 2024

Fixes #8109.

@isoos isoos requested review from jonasfj and sigurdm November 20, 2024 14:29
@isoos
Copy link
Collaborator Author

isoos commented Nov 20, 2024

/cc @parlough this looks like another item that should be easy to standardize on, what do you think?

Note: dartdoc uses another set of font sizes :(

@parlough
Copy link
Member

parlough commented Nov 20, 2024

/cc @parlough this looks like another item that should be easy to standardize on, what do you think?

Makes sense to me, perhaps besides h1 which is more likely to be different depending on site layout.

Comment on lines +52 to +54
h4 { font-size: 18px; } // note: github uses 1em, ~16px
h5 { font-size: 17px; } // note: github uses 0.875em, ~14px
h6 { font-size: 16px; } // note: github uses 0.85em, ~13.6px
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect these are a bit close, but I'm not too worried.

From what I can tell wikipedia has the same size for h4 - h6

image

with lines under h1 and h2, and h3 only being slightly larger.

Just saying it's an option to not have different sizes.

Copy link
Member

@jonasfj jonasfj Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I note that it might be more importnat to have a larger difference between h3 and h4, than having any difference between h4-h6

People rarely use h5 and h6.

If we wanted to make using h1-h6 usable, we should perhaps consider numbering headlines.

1. h1

1.1 h2

1.1.1 h3

1.1.1.1 h4

1.1.1.1.1 h5
1.1.1.1.1.1 h6

But this can also be a bit degenerate in it's own right... Though we could put 1.1.1.1.1 in the margin and make it only show up when hovering a headline, or something like that.

(I'm not actually proposing we do this, just saying that would be an option).


Mostly I'm saying we could consider not having a difference in size between h4-h6 as they are rarely used. Allowing us have a large difference between h3 and h4 (which is more commonly reached).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a table of contents hovering/updating/folding/unfolding as you scroll may be better than numbers.

Copy link
Member

@jonasfj jonasfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I don't have strong feelings here.

@isoos isoos merged commit c95ce19 into dart-lang:master Nov 21, 2024
32 checks passed
@isoos isoos deleted the font-sizes branch November 21, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

h3 and h4 headings have the same font size

4 participants