-
Notifications
You must be signed in to change notification settings - Fork 166
Use different font size for h3 and h4 in markdown formatted content. #8322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/cc @parlough this looks like another item that should be easy to standardize on, what do you think? Note: dartdoc uses another set of font sizes :( |
Makes sense to me, perhaps besides |
Co-authored-by: Sigurd Meldgaard <[email protected]>
| h4 { font-size: 18px; } // note: github uses 1em, ~16px | ||
| h5 { font-size: 17px; } // note: github uses 0.875em, ~14px | ||
| h6 { font-size: 16px; } // note: github uses 0.85em, ~13.6px |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I note that it might be more importnat to have a larger difference between h3 and h4, than having any difference between h4-h6
People rarely use h5 and h6.
If we wanted to make using h1-h6 usable, we should perhaps consider numbering headlines.
1. h1
1.1 h2
1.1.1 h3
1.1.1.1 h4
1.1.1.1.1 h5
1.1.1.1.1.1 h6
But this can also be a bit degenerate in it's own right... Though we could put 1.1.1.1.1 in the margin and make it only show up when hovering a headline, or something like that.
(I'm not actually proposing we do this, just saying that would be an option).
Mostly I'm saying we could consider not having a difference in size between h4-h6 as they are rarely used. Allowing us have a large difference between h3 and h4 (which is more commonly reached).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a table of contents hovering/updating/folding/unfolding as you scroll may be better than numbers.
jonasfj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I don't have strong feelings here.

Fixes #8109.