Skip to content

Minor scss cleanup and updates before use migration #8353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Minor scss cleanup and updates before use migration #8353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/web_css/lib/src/_footer.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
/* Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
for details. All rights reserved. Use of this source code is governed by a
BSD-style license that can be found in the LICENSE file. */

/******************************************************
site footer
******************************************************/
Expand Down
6 changes: 5 additions & 1 deletion pkg/web_css/lib/src/_home.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
/* Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
for details. All rights reserved. Use of this source code is governed by a
BSD-style license that can be found in the LICENSE file. */

/******************************************************
home page
******************************************************/
Expand Down Expand Up @@ -91,7 +95,7 @@
z-index: 0;

> img {
max-height: 240px; // effective max-heigh: 240 * 1.25 = 300px, 75% of two cards total height.
max-height: 240px; // effective max-height: 240 * 1.25 = 300px, 75% of two cards total height.
}
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/web_css/lib/src/_scores.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
white-space: nowrap;

@media (min-width: $device-desktop-min-width) {
font-size: 12x;
font-size: 12px;
letter-spacing: 0.2px;
}

Expand Down
2 changes: 0 additions & 2 deletions pkg/web_css/lib/src/_search.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@
border: none;
border-radius: 24px;
width: 150px;
-webkit-box-flex: 1;
-ms-flex-positive: 1;
flex-grow: 1;
background: var(--pub-searchbar_input-background-color);
color: var(--pub-searchbar_input-text-color);
Expand Down
4 changes: 4 additions & 0 deletions pkg/web_css/lib/src/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
/* Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
for details. All rights reserved. Use of this source code is governed by a
BSD-style license that can be found in the LICENSE file. */

// suggested naming convention:
//
// color definitions:
Expand Down
4 changes: 4 additions & 0 deletions pkg/web_css/lib/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
/* Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
for details. All rights reserved. Use of this source code is governed by a
BSD-style license that can be found in the LICENSE file. */

// Include third-party CSS into a single output file
// to reduce the number of HTTP requests.
@use '../../../third_party/css/github-markdown.css';
Expand Down
2 changes: 1 addition & 1 deletion pkg/web_css/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ environment:
resolution: workspace

dependencies:
sass: ^1.32.8
sass: ^1.81.1

dev_dependencies:
csslib: ^1.0.0
Expand Down
8 changes: 4 additions & 4 deletions pubspec.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,10 +186,10 @@ packages:
dependency: transitive
description:
name: cli_pkg
sha256: f812467b5d6a5f26ad0fba5dcfc95133df02edbae47dfa4ade3df5d2b5afdcf2
sha256: f07db5590796444efdfdc7549e596949b74ce2b707c6a2dfd1f9d841d8337dd4
url: "https://pub.dev"
source: hosted
version: "2.10.0"
version: "2.11.0"
cli_repl:
dependency: transitive
description:
Expand Down Expand Up @@ -722,10 +722,10 @@ packages:
dependency: transitive
description:
name: sass
sha256: e656cc9f827c236b6b043232cd9b8b5a1d2094e9f01a49936aeccc50d2e871a2
sha256: "21ba7cdfd759d0fce641a24052fe9a2d7dff89bf8c56f64a4b9e1f67727db6af"
url: "https://pub.dev"
source: hosted
version: "1.78.0"
version: "1.81.1"
shelf:
dependency: transitive
description:
Expand Down
Loading