Skip to content

Prevent any work if search query offset is outside of document range. #8378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Prevent any work if search query offset is outside of document range. #8378

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions app/lib/search/mem_index.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,14 @@ class InMemoryPackageIndex {
}

PackageSearchResult search(ServiceSearchQuery query) {
// prevent any work if offset is outside of the range
if ((query.offset ?? 0) > _documents.length) {
return PackageSearchResult(
timestamp: clock.now(),
totalCount: 0,
packageHits: [],
);
}
return _scorePool.withScore(
value: 1.0,
fn: (score) {
Expand Down
Loading