Skip to content

Change label of pub points in infobox #8383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Change label of pub points in infobox #8383

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1d4e464
Change label of pub points in infobox
szakarias Dec 10, 2024
1512128
templates test
szakarias Dec 10, 2024
12bc112
Merge branch 'points' of https://github.com/szakarias/pub-dev into po…
isoos Dec 10, 2024
5928745
Updated task end2end goldens.
isoos Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions app/lib/frontend/templates/views/pkg/labeled_scores.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ d.Node labeledScoresNode({
),
d.div(
classes: ['packages-score', 'packages-score-health'],
child:
_labeledScore('pub points', grantedPubPoints?.toString(), sign: ''),
child: _labeledScore('points', grantedPubPoints?.toString(), sign: ''),
),
requestContext.experimentalFlags.showDownloadCounts
? d.div(
Expand Down
4 changes: 2 additions & 2 deletions app/test/frontend/golden/my_packages.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ <h3 class="packages-title">
<span class="packages-score-value-number">54</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">pub points</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
Expand Down Expand Up @@ -293,7 +293,7 @@ <h3 class="packages-title">
<span class="packages-score-value-number">44</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">pub points</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
Expand Down
4 changes: 2 additions & 2 deletions app/test/frontend/golden/pkg_activity_log_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ <h3 class="detail-lead-title">Metadata</h3>
<span class="packages-score-value-number">54</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">pub points</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
Expand Down Expand Up @@ -444,7 +444,7 @@ <h3 class="detail-metadata-title">
<span class="packages-score-value-number">54</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">pub points</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
Expand Down
4 changes: 2 additions & 2 deletions app/test/frontend/golden/pkg_admin_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,7 +653,7 @@ <h3>Restore retracted package version</h3>
<span class="packages-score-value-number">54</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">pub points</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
Expand Down Expand Up @@ -729,7 +729,7 @@ <h3 class="detail-metadata-title">
<span class="packages-score-value-number">54</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">pub points</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
Expand Down
4 changes: 2 additions & 2 deletions app/test/frontend/golden/pkg_changelog_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ <h2 class="changelog-version hash-header" id="120">
<span class="packages-score-value-number">54</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">pub points</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
Expand Down Expand Up @@ -315,7 +315,7 @@ <h3 class="detail-metadata-title">
<span class="packages-score-value-number">54</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">pub points</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
Expand Down
4 changes: 2 additions & 2 deletions app/test/frontend/golden/pkg_example_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ <h3 class="detail-lead-title">Metadata</h3>
<span class="packages-score-value-number">54</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">pub points</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
Expand Down Expand Up @@ -312,7 +312,7 @@ <h3 class="detail-metadata-title">
<span class="packages-score-value-number">54</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">pub points</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
Expand Down
4 changes: 2 additions & 2 deletions app/test/frontend/golden/pkg_index_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,7 @@ <h3 class="packages-title">
<span class="packages-score-value-number">54</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">pub points</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
Expand Down Expand Up @@ -560,7 +560,7 @@ <h3 class="packages-title">
<span class="packages-score-value-number">38</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">pub points</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
Expand Down
4 changes: 2 additions & 2 deletions app/test/frontend/golden/pkg_install_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ <h3>Import it</h3>
<span class="packages-score-value-number">54</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">pub points</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
Expand Down Expand Up @@ -338,7 +338,7 @@ <h3 class="detail-metadata-title">
<span class="packages-score-value-number">54</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">pub points</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
Expand Down
4 changes: 2 additions & 2 deletions app/test/frontend/golden/pkg_score_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ <h3>
<span class="packages-score-value-number">54</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">pub points</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
Expand Down Expand Up @@ -400,7 +400,7 @@ <h3 class="detail-metadata-title">
<span class="packages-score-value-number">54</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">pub points</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
Expand Down
4 changes: 2 additions & 2 deletions app/test/frontend/golden/pkg_score_page_with_downloads_chart.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ <h3>
<span class="packages-score-value-number">54</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">pub points</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
Expand Down Expand Up @@ -400,7 +400,7 @@ <h3 class="detail-metadata-title">
<span class="packages-score-value-number">54</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">pub points</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
Expand Down
4 changes: 2 additions & 2 deletions app/test/frontend/golden/pkg_show_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ <h1 class="hash-header" id="oxygen">
<span class="packages-score-value-number">54</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">pub points</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
Expand Down Expand Up @@ -315,7 +315,7 @@ <h3 class="detail-metadata-title">
<span class="packages-score-value-number">54</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">pub points</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
Expand Down
4 changes: 2 additions & 2 deletions app/test/frontend/golden/pkg_show_page_discontinued.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ <h1 class="hash-header" id="pkg">
<span class="packages-score-value-number">17</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">pub points</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
Expand Down Expand Up @@ -308,7 +308,7 @@ <h3 class="detail-metadata-title">
<span class="packages-score-value-number">17</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">pub points</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
Expand Down
4 changes: 2 additions & 2 deletions app/test/frontend/golden/pkg_show_page_flutter_plugin.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ <h1 class="hash-header" id="flutter_titanium">
<span class="packages-score-value-number">38</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">pub points</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
Expand Down Expand Up @@ -308,7 +308,7 @@ <h3 class="detail-metadata-title">
<span class="packages-score-value-number">38</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">pub points</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
Expand Down
4 changes: 2 additions & 2 deletions app/test/frontend/golden/pkg_show_page_publisher.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ <h1 class="hash-header" id="neon">
<span class="packages-score-value-number">44</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">pub points</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
Expand Down Expand Up @@ -306,7 +306,7 @@ <h3 class="detail-metadata-title">
<span class="packages-score-value-number">44</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">pub points</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
Expand Down
4 changes: 2 additions & 2 deletions app/test/frontend/golden/pkg_show_page_retracted.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ <h1 class="hash-header" id="pkg">
<span class="packages-score-value-number">0</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">pub points</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
Expand Down Expand Up @@ -284,7 +284,7 @@ <h3 class="detail-metadata-title">
<span class="packages-score-value-number">0</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">pub points</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
Expand Down
4 changes: 2 additions & 2 deletions app/test/frontend/golden/pkg_show_page_retracted_non_retracted_version.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ <h1 class="hash-header" id="pkg">
<span class="packages-score-value-number">33</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">pub points</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
Expand Down Expand Up @@ -299,7 +299,7 @@ <h3 class="detail-metadata-title">
<span class="packages-score-value-number">33</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">pub points</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
Expand Down
4 changes: 2 additions & 2 deletions app/test/frontend/golden/pkg_show_version_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ <h1 class="hash-header" id="oxygen">
<span class="packages-score-value-number">54</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">pub points</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
Expand Down Expand Up @@ -309,7 +309,7 @@ <h3 class="detail-metadata-title">
<span class="packages-score-value-number">54</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">pub points</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
Expand Down
4 changes: 2 additions & 2 deletions app/test/frontend/golden/pkg_versions_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ <h2 id="prerelease">Prerelease versions of oxygen</h2>
<span class="packages-score-value-number">54</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">pub points</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
Expand Down Expand Up @@ -422,7 +422,7 @@ <h3 class="detail-metadata-title">
<span class="packages-score-value-number">54</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">pub points</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
Expand Down
4 changes: 2 additions & 2 deletions app/test/frontend/golden/publisher_packages_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ <h3 class="packages-title">
<span class="packages-score-value-number">44</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">pub points</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
Expand Down Expand Up @@ -293,7 +293,7 @@ <h3 class="packages-title">
<span class="packages-score-value-number">38</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">pub points</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
Expand Down
4 changes: 2 additions & 2 deletions app/test/frontend/golden/publisher_unlisted_packages_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ <h3 class="packages-title">
<span class="packages-score-value-number">44</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">pub points</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
Expand Down Expand Up @@ -299,7 +299,7 @@ <h3 class="packages-title">
<span class="packages-score-value-number">38</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">pub points</div>
<div class="packages-score-label">points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
Expand Down
Loading
Loading