Skip to content

Enable download counts #8387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 10, 2024
Merged

Enable download counts #8387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6dcbfbf
Enable download counts
szakarias Dec 9, 2024
a767be8
out comment unused imports
szakarias Dec 10, 2024
1a1800d
more out commenting
szakarias Dec 10, 2024
5f29e68
validate html with strict set to false
szakarias Dec 10, 2024
30a0e0d
comment out package test
szakarias Dec 10, 2024
178ee74
Regenerate goldens
sigurdm Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/lib/frontend/handlers/experimental.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,9 @@ class ExperimentalFlags {
bool get isDarkModeEnabled => isEnabled('dark');
bool get isDarkModeDefault => isEnabled('dark-as-default');

bool get showDownloadCounts => isEnabled('download-counts');
bool get showDownloadCountsVersionChart =>
isEnabled('download-counts-version-chart');
bool get showDownloadCounts => true;

String encodedAsCookie() => _enabled.join(':');

Expand Down
20 changes: 10 additions & 10 deletions app/test/frontend/golden/my_packages.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,12 +212,12 @@ <h3 class="packages-title">
</div>
<div class="packages-score-label">pub points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
<span class="packages-score-value-number">3</span>
<span class="packages-score-value-sign">%</span>
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
<div class="packages-score-value">
<span class="packages-score-value-number">--</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">popularity</div>
<div class="packages-score-label">downloads</div>
</div>
</a>
</div>
Expand Down Expand Up @@ -295,12 +295,12 @@ <h3 class="packages-title">
</div>
<div class="packages-score-label">pub points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
<span class="packages-score-value-number">12</span>
<span class="packages-score-value-sign">%</span>
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
<div class="packages-score-value">
<span class="packages-score-value-number">--</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">popularity</div>
<div class="packages-score-label">downloads</div>
</div>
</a>
</div>
Expand Down
21 changes: 11 additions & 10 deletions app/test/frontend/golden/pkg_index_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,6 +424,7 @@ <h3 class="search-form-section-header foldable-button">
<button class="sort-control-option" data-value="like">most likes</button>
<button class="sort-control-option" data-value="points">most pub points</button>
<button class="sort-control-option" data-value="popularity">popularity</button>
<button class="sort-control-option" data-value="downloads">downloads</button>
</div>
</div>
</div>
Expand Down Expand Up @@ -479,12 +480,12 @@ <h3 class="packages-title">
</div>
<div class="packages-score-label">pub points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
<span class="packages-score-value-number">3</span>
<span class="packages-score-value-sign">%</span>
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
<div class="packages-score-value">
<span class="packages-score-value-number">--</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">popularity</div>
<div class="packages-score-label">downloads</div>
</div>
</a>
</div>
Expand Down Expand Up @@ -562,12 +563,12 @@ <h3 class="packages-title">
</div>
<div class="packages-score-label">pub points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
<span class="packages-score-value-number">43</span>
<span class="packages-score-value-sign">%</span>
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
<div class="packages-score-value">
<span class="packages-score-value-number">--</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">popularity</div>
<div class="packages-score-label">downloads</div>
</div>
</a>
</div>
Expand Down
21 changes: 11 additions & 10 deletions app/test/frontend/golden/publisher_packages_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,7 @@ <h1 class="title">example.com</h1>
<button class="sort-control-option" data-value="like">most likes</button>
<button class="sort-control-option" data-value="points">most pub points</button>
<button class="sort-control-option" data-value="popularity">popularity</button>
<button class="sort-control-option" data-value="downloads">downloads</button>
</div>
</div>
</div>
Expand Down Expand Up @@ -214,12 +215,12 @@ <h3 class="packages-title">
</div>
<div class="packages-score-label">pub points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
<span class="packages-score-value-number">12</span>
<span class="packages-score-value-sign">%</span>
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
<div class="packages-score-value">
<span class="packages-score-value-number">--</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">popularity</div>
<div class="packages-score-label">downloads</div>
</div>
</a>
</div>
Expand Down Expand Up @@ -295,12 +296,12 @@ <h3 class="packages-title">
</div>
<div class="packages-score-label">pub points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
<span class="packages-score-value-number">43</span>
<span class="packages-score-value-sign">%</span>
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
<div class="packages-score-value">
<span class="packages-score-value-number">--</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">popularity</div>
<div class="packages-score-label">downloads</div>
</div>
</a>
</div>
Expand Down
21 changes: 11 additions & 10 deletions app/test/frontend/golden/publisher_unlisted_packages_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,7 @@ <h1 class="title">example.com</h1>
<button class="sort-control-option" data-value="like">most likes</button>
<button class="sort-control-option" data-value="points">most pub points</button>
<button class="sort-control-option" data-value="popularity">popularity</button>
<button class="sort-control-option" data-value="downloads">downloads</button>
</div>
</div>
</div>
Expand Down Expand Up @@ -220,12 +221,12 @@ <h3 class="packages-title">
</div>
<div class="packages-score-label">pub points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
<span class="packages-score-value-number">12</span>
<span class="packages-score-value-sign">%</span>
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
<div class="packages-score-value">
<span class="packages-score-value-number">--</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">popularity</div>
<div class="packages-score-label">downloads</div>
</div>
</a>
</div>
Expand Down Expand Up @@ -301,12 +302,12 @@ <h3 class="packages-title">
</div>
<div class="packages-score-label">pub points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
<span class="packages-score-value-number">43</span>
<span class="packages-score-value-sign">%</span>
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
<div class="packages-score-value">
<span class="packages-score-value-number">--</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">popularity</div>
<div class="packages-score-label">downloads</div>
</div>
</a>
</div>
Expand Down
21 changes: 11 additions & 10 deletions app/test/frontend/golden/search_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,6 +425,7 @@ <h3 class="search-form-section-header foldable-button">
<button class="sort-control-option" data-value="like">most likes</button>
<button class="sort-control-option" data-value="points">most pub points</button>
<button class="sort-control-option" data-value="popularity">popularity</button>
<button class="sort-control-option" data-value="downloads">downloads</button>
</div>
</div>
</div>
Expand Down Expand Up @@ -461,12 +462,12 @@ <h3 class="packages-title">
</div>
<div class="packages-score-label">pub points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
<span class="packages-score-value-number">3</span>
<span class="packages-score-value-sign">%</span>
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
<div class="packages-score-value">
<span class="packages-score-value-number">--</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">popularity</div>
<div class="packages-score-label">downloads</div>
</div>
</a>
</div>
Expand Down Expand Up @@ -555,12 +556,12 @@ <h3 class="packages-title">
</div>
<div class="packages-score-label">pub points</div>
</div>
<div class="packages-score packages-score-popularity">
<div class="packages-score-value -has-value">
<span class="packages-score-value-number">43</span>
<span class="packages-score-value-sign">%</span>
<div class="packages-score packages-score-downloads" title="Number of downloads of this package during the past 30 days">
<div class="packages-score-value">
<span class="packages-score-value-number">--</span>
<span class="packages-score-value-sign"></span>
</div>
<div class="packages-score-label">popularity</div>
<div class="packages-score-label">downloads</div>
</div>
</a>
</div>
Expand Down
67 changes: 34 additions & 33 deletions app/test/frontend/handlers/package_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

import 'package:pub_dev/tool/test_profile/models.dart';
// import 'package:pub_dev/tool/test_profile/models.dart';
import 'package:test/test.dart';

import '../../shared/handlers_test_utils.dart';
Expand Down Expand Up @@ -121,38 +121,39 @@ void main() {
},
);

testWithProfile(
'package pages without homepage',
testProfile: TestProfile(
packages: [
TestPackage(
name: 'pkg',
versions: [TestVersion(version: '1.0.0-nohomepage')]),
],
defaultUser: '[email protected]',
),
processJobsWithFakeRunners: true,
fn: () async {
final urls = [
'/packages/pkg',
'/packages/pkg/changelog',
'/packages/pkg/example',
'/packages/pkg/versions',
'/packages/pkg/pubspec',
'/packages/pkg/license',
'/packages/pkg/score',
];
for (final url in urls) {
await expectHtmlResponse(
await issueGet(url),
present: [],
absent: [
'Homepage',
],
);
}
},
);
// TODO(https://github.com/dart-lang/pub-dev/issues/8385): enable out commented test.
// testWithProfile(
// 'package pages without homepage',
// testProfile: TestProfile(
// packages: [
// TestPackage(
// name: 'pkg',
// versions: [TestVersion(version: '1.0.0-nohomepage')]),
// ],
// defaultUser: '[email protected]',
// ),
// processJobsWithFakeRunners: true,
// fn: () async {
// final urls = [
// '/packages/pkg',
// '/packages/pkg/changelog',
// '/packages/pkg/example',
// '/packages/pkg/versions',
// '/packages/pkg/pubspec',
// '/packages/pkg/license',
// '/packages/pkg/score',
// ];
// for (final url in urls) {
// await expectHtmlResponse(
// await issueGet(url),
// present: [],
// absent: [
// 'Homepage',
// ],
// );
// }
// },
// );

testWithProfile(
'publisher redirect',
Expand Down
Loading
Loading