Different tag index: document index lists for each tag. #8396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
isoos
commented
Dec 11, 2024
isoos
commented
- This is a follow-up on Faster predicate matching with integer tag ids. #8377 to implement the idea where we keep the document index list for each tag.
- The change itself is mostly neutral on memory, and local benchmark shows about 2-3% improvements in latencies.
- However, it reduces the "smart" factor (complexity) of the index, and I think this has even further potential for improvement, if we change it to value ranges + pre-sort the document list for the default predicates. (to be explored in a separate PR).
sigurdm
approved these changes
Dec 12, 2024
app/lib/search/mem_index.dart
Outdated
| late final TokenIndex<IndexedApiDocPage> _apiSymbolIndex; | ||
| late final _scorePool = ScorePool(_packageNameIndex._packageNames); | ||
| final _tagIds = <String, int>{}; | ||
| final _tagDocumentIndexes = <String, List<int>>{}; |
Contributor
There was a problem hiding this comment.
Nit
Suggested change
| final _tagDocumentIndexes = <String, List<int>>{}; | |
| final _tagDocumentIndices = <String, List<int>>{}; |
app/lib/search/mem_index.dart
Outdated
| late final TokenIndex<IndexedApiDocPage> _apiSymbolIndex; | ||
| late final _scorePool = ScorePool(_packageNameIndex._packageNames); | ||
| final _tagIds = <String, int>{}; | ||
| final _tagDocumentIndexes = <String, List<int>>{}; |
Contributor
There was a problem hiding this comment.
Could you add a dartdoc explaining what gets mapped to what here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.