Upgrade runtime SDK

CHANGELOG.md

@@ -2,6 +2,8 @@ Important changes to data models, configuration, and migrations between each
 AppEngine version, listed here to ease deployment and troubleshooting.
 
 ## Next Release (replace with git tag when deployed)
+ * Bump runtimeVersion to `2024.12.12`.
+ * Upgraded runtime Dart SDK to `3.6.0`.
 
 ## `20241212t111200-all`
  * Bump runtimeVersion to `2024.12.11`.

app/lib/shared/versions.dart

@@ -24,8 +24,9 @@ final RegExp runtimeVersionPattern = RegExp(r'^\d{4}\.\d{2}\.\d{2}$');
 /// when the version switch happens.
 const _acceptedRuntimeVersions = <String>[
   // The current [runtimeVersion].
-  '2024.12.11',
+  '2024.12.12',
   // Fallback runtime versions.
+  '2024.12.11',
   '2024.12.09',
   '2024.12.04',
 ];
@@ -61,7 +62,7 @@ bool shouldGCVersion(String version) =>
     version.compareTo(gcBeforeRuntimeVersion) < 0;
 
 // keep in-sync with SDK version in .mono_repo.yml and Dockerfile
-final String runtimeSdkVersion = '3.5.0';
+final String runtimeSdkVersion = '3.6.0';
 final String toolStableDartSdkVersion = '3.6.0';
 final String toolStableFlutterSdkVersion = '3.27.0';
 

app/test/task/end2end_test.dart

@@ -12,13 +12,14 @@ import 'package:pub_dev/tool/test_profile/models.dart';
 import 'package:test/test.dart';
 
 import '../frontend/handlers/_utils.dart';
+import '../shared/handlers_test_utils.dart';
 import '../shared/test_services.dart';
 import '../shared/utils.dart';
 
 const String goldenDir = 'test/task/testdata/goldens';
 
 // TODO: generalize golden testing, use env var for regenerating all goldens.
-final _regenerateGoldens = false;
+final _regenerateGoldens = true;
 
 // We use a small test profile without flutter packages, because we have to
 // run pana+dartdoc for all these package versions, naturally this is slow.
@@ -44,9 +45,8 @@ void main() {
   testWithProfile('output of oxygen', testProfile: _testProfile, fn: () async {
     await processTasksLocallyWithPubWorker();
     // Make assertions about generated documentation
-    final doc = await _fetchHtmlDocument(
-      '/documentation/oxygen/latest/oxygen/oxygen-library.html',
-    );
+    final doc =
+        await _fetchHtmlDocument('/documentation/oxygen/latest/oxygen/');
     // Check that .self-crumb made it through
     expect(doc.querySelector('.self-crumb')!.text, contains('oxygen'));
     // Check that we don't have noindex on /latest/
@@ -56,6 +56,11 @@ void main() {
           m.attributes['content'] == 'noindex'),
       isEmpty,
     );
+    // check old library file redirect
+    await expectRedirectResponse(
+      await issueGet('/documentation/oxygen/latest/oxygen/oxygen-library.html'),
+      '/documentation/oxygen/latest/oxygen/',
+    );
 
     // Traverse all package pages and generated documentation,
     // create golden files and check for dead links and assets

app/test/task/testdata/goldens/documentation/oxygen/1.0.0/index.html

@@ -55,7 +55,7 @@ <h2>Libraries</h2>
           <dl>
             <dt id="oxygen">
               <span class="name">
-                <a href="oxygen/oxygen-library.html">oxygen</a>
+                <a href="oxygen">oxygen</a>
               </span>
             </dt>
             <dd></dd>
@@ -82,7 +82,7 @@ <h5 class="hidden-xs">
         <ol>
           <li class="section-title">Libraries</li>
           <li>
-            <a href="oxygen/oxygen-library.html">oxygen</a>
+            <a href="oxygen">oxygen</a>
           </li>
         </ol>
         <div id="dartdoc-sidebar-left-content"></div>

app/test/task/testdata/goldens/documentation/oxygen/1.0.0/oxygen/MainClass-class.html

@@ -34,7 +34,7 @@
           <a href="../index.html">documentation</a>
         </li>
         <li>
-          <a href="../oxygen/oxygen-library.html">oxygen.dart</a>
+          <a href="../oxygen">oxygen.dart</a>
         </li>
         <li class="self-crumb">MainClass class</li>
       </ol>
@@ -243,7 +243,7 @@ <h2>Operators</h2>
             <a href="../index.html">documentation</a>
           </li>
           <li>
-            <a href="../oxygen/oxygen-library.html">oxygen</a>
+            <a href="../oxygen">oxygen</a>
           </li>
           <li class="self-crumb">MainClass class</li>
         </ol>

app/test/task/testdata/goldens/documentation/oxygen/1.0.0/oxygen/MainClass/MainClass.html

@@ -34,7 +34,7 @@
           <a href="../../index.html">documentation</a>
         </li>
         <li>
-          <a href="../../oxygen/oxygen-library.html">oxygen.dart</a>
+          <a href="../../oxygen">oxygen.dart</a>
         </li>
         <li>
           <a href="../../oxygen/MainClass-class.html">MainClass</a>
@@ -100,7 +100,7 @@ <h2>
             <a href="../../index.html">documentation</a>
           </li>
           <li>
-            <a href="../../oxygen/oxygen-library.html">oxygen</a>
+            <a href="../../oxygen">oxygen</a>
           </li>
           <li>
             <a href="../../oxygen/MainClass-class.html">MainClass</a>

app/test/task/testdata/goldens/documentation/oxygen/1.0.0/oxygen/MainClass/text.html

@@ -34,7 +34,7 @@
           <a href="../../index.html">documentation</a>
         </li>
         <li>
-          <a href="../../oxygen/oxygen-library.html">oxygen.dart</a>
+          <a href="../../oxygen">oxygen.dart</a>
         </li>
         <li>
           <a href="../../oxygen/MainClass-class.html">MainClass</a>
@@ -91,7 +91,7 @@ <h2>
             <a href="../../index.html">documentation</a>
           </li>
           <li>
-            <a href="../../oxygen/oxygen-library.html">oxygen</a>
+            <a href="../../oxygen">oxygen</a>
           </li>
           <li>
             <a href="../../oxygen/MainClass-class.html">MainClass</a>

app/test/task/testdata/goldens/documentation/oxygen/1.0.0/oxygen/MainClass/toLowerCase.html

@@ -34,7 +34,7 @@
           <a href="../../index.html">documentation</a>
         </li>
         <li>
-          <a href="../../oxygen/oxygen-library.html">oxygen.dart</a>
+          <a href="../../oxygen">oxygen.dart</a>
         </li>
         <li>
           <a href="../../oxygen/MainClass-class.html">MainClass</a>
@@ -100,7 +100,7 @@ <h2>
             <a href="../../index.html">documentation</a>
           </li>
           <li>
-            <a href="../../oxygen/oxygen-library.html">oxygen</a>
+            <a href="../../oxygen">oxygen</a>
           </li>
           <li>
             <a href="../../oxygen/MainClass-class.html">MainClass</a>

app/test/task/testdata/goldens/documentation/oxygen/1.0.0/oxygen/MainClass/toString.html

@@ -34,7 +34,7 @@
           <a href="../../index.html">documentation</a>
         </li>
         <li>
-          <a href="../../oxygen/oxygen-library.html">oxygen.dart</a>
+          <a href="../../oxygen">oxygen.dart</a>
         </li>
         <li>
           <a href="../../oxygen/MainClass-class.html">MainClass</a>
@@ -119,7 +119,7 @@ <h2>
             <a href="../../index.html">documentation</a>
           </li>
           <li>
-            <a href="../../oxygen/oxygen-library.html">oxygen</a>
+            <a href="../../oxygen">oxygen</a>
           </li>
           <li>
             <a href="../../oxygen/MainClass-class.html">MainClass</a>

app/test/task/testdata/goldens/documentation/oxygen/1.0.0/oxygen/TypeEnum.html

@@ -34,7 +34,7 @@
           <a href="../index.html">documentation</a>
         </li>
         <li>
-          <a href="../oxygen/oxygen-library.html">oxygen.dart</a>
+          <a href="../oxygen">oxygen.dart</a>
         </li>
         <li class="self-crumb">TypeEnum enum</li>
       </ol>
@@ -138,6 +138,30 @@ <h2>Properties</h2>
                 <span class="feature">inherited</span>
               </div>
             </dd>
+            <dt id="name" class="property">
+              <span class="name">
+                <a href="https://api.dart.dev/stable/%%stable-dart-version%%/dart-core/EnumName/name.html">name</a>
+              </span>
+              <span class="signature">
+                →
+                <a href="https://api.dart.dev/stable/%%stable-dart-version%%/dart-core/String-class.html">String</a>
+              </span>
+            </dt>
+            <dd>
+              <p class="from-extension">
+                <span>
+                  Available on
+                  <a href="https://api.dart.dev/stable/%%stable-dart-version%%/dart-core/Enum-class.html">Enum</a>
+                  , provided by the
+                  <a href="https://api.dart.dev/stable/%%stable-dart-version%%/dart-core/EnumName.html">EnumName</a>
+                  extension
+                </span>
+              </p>
+              The name of the enum value.
+              <div class="features">
+                <span class="feature">no setter</span>
+              </div>
+            </dd>
             <dt id="runtimeType" class="property inherited">
               <span class="name">
                 <a href="https://api.dart.dev/stable/%%stable-dart-version%%/dart-core/Object/runtimeType.html">runtimeType</a>
@@ -273,7 +297,7 @@ <h2>Constants</h2>
             <a href="../index.html">documentation</a>
           </li>
           <li>
-            <a href="../oxygen/oxygen-library.html">oxygen</a>
+            <a href="../oxygen">oxygen</a>
           </li>
           <li class="self-crumb">TypeEnum enum</li>
         </ol>

app/test/task/testdata/goldens/documentation/oxygen/1.0.0/oxygen/TypeEnum/values-constant.html

@@ -34,7 +34,7 @@
           <a href="../../index.html">documentation</a>
         </li>
         <li>
-          <a href="../../oxygen/oxygen-library.html">oxygen.dart</a>
+          <a href="../../oxygen">oxygen.dart</a>
         </li>
         <li>
           <a href="../../oxygen/TypeEnum.html">TypeEnum</a>
@@ -92,7 +92,7 @@ <h1>
             <a href="../../index.html">documentation</a>
           </li>
           <li>
-            <a href="../../oxygen/oxygen-library.html">oxygen</a>
+            <a href="../../oxygen">oxygen</a>
           </li>
           <li>
             <a href="../../oxygen/TypeEnum.html">TypeEnum</a>

app/test/task/testdata/goldens/documentation/oxygen/1.0.0/oxygen/oxygen-library.html → app/test/task/testdata/goldens/documentation/oxygen/1.0.0/oxygen/index.html

@@ -10,7 +10,7 @@
     <meta name="generator" content="made with love by dartdoc"/>
     <meta name="description" content="oxygen library API docs, for the Dart programming language."/>
     <title>oxygen library - Dart API</title>
-    <link rel="canonical" href="https://pub.dev/documentation/oxygen/1.0.0/oxygen/oxygen-library.html"/>
+    <link rel="canonical" href="https://pub.dev/documentation/oxygen/1.0.0/oxygen"/>
     <meta rel="alternate" href="/documentation/oxygen/latest/"/>
     <link rel="preconnect" href="https://fonts.gstatic.com"/>
     <link rel="stylesheet" href="https://fonts.googleapis.com/css2?family=Roboto+Mono:ital,wght@0,300;0,400;0,500;0,700;1,400&amp;display=swap"/>
@@ -118,7 +118,7 @@ <h5>
         <ol>
           <li class="section-title">Libraries</li>
           <li>
-            <a href="../oxygen/oxygen-library.html">oxygen</a>
+            <a href="../oxygen">oxygen</a>
           </li>
         </ol>
         <div id="dartdoc-sidebar-left-content"></div>

app/test/task/testdata/goldens/documentation/oxygen/1.0.0/oxygen/main.html

@@ -34,7 +34,7 @@
           <a href="../index.html">documentation</a>
         </li>
         <li>
-          <a href="../oxygen/oxygen-library.html">oxygen.dart</a>
+          <a href="../oxygen">oxygen.dart</a>
         </li>
         <li class="self-crumb">main function</li>
       </ol>
@@ -88,7 +88,7 @@ <h2>
             <a href="../index.html">documentation</a>
           </li>
           <li>
-            <a href="../oxygen/oxygen-library.html">oxygen</a>
+            <a href="../oxygen">oxygen</a>
           </li>
           <li class="self-crumb">main function</li>
         </ol>