Skip to content

Downloads chart - small adjustments #8530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Downloads chart - small adjustments #8530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions app/lib/frontend/templates/views/pkg/score_tab.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,6 @@ d.Node scoreTabNode({
],
),
_reportNode(report),
if (card.weeklyVersionDownloads != null &&
requestContext.experimentalFlags.showDownloadCountsVersionChart)
_downloadsChart(card.weeklyVersionDownloads!),
if (toolEnvInfo != null) toolEnvInfo,
]),
if (!showPending)
Expand All @@ -98,6 +95,9 @@ d.Node scoreTabNode({
d.text(' for details.'),
],
),
if (card.weeklyVersionDownloads != null &&
requestContext.experimentalFlags.showDownloadCountsVersionChart)
_downloadsChart(card.weeklyVersionDownloads!),
]);
}

Expand Down Expand Up @@ -207,7 +207,7 @@ d.Node _downloadsChart(WeeklyVersionDownloadCounts weeklyVersionDownloads) {
);

return d.fragment([
d.h1(text: 'Weekly Downloads over the last 40 weeks'),
d.h1(text: 'Weekly downloads'),
versionModes,
container,
]);
Expand Down
11 changes: 1 addition & 10 deletions pkg/web_app/lib/src/widget/downloads_chart/widget.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ void drawChart(
}

final longTick = SVGPathElement();
longTick.setAttribute('class', 'downloads-chart-frame');
longTick.setAttribute('class', 'downloads-chart-axis-line');
longTick.setAttribute('d', 'M$xAxisStart $y L$xAxisEnd $y');
chart.append(longTick);
}
Expand Down Expand Up @@ -291,13 +291,4 @@ void drawChart(
legendLabel.getBBox().width +
labelPadding;
}

final frameHeight = legendY + marginPadding + labelPadding;
final frame = SVGRectElement()
..setAttribute('class', 'downloads-chart-frame')
..setAttribute('height', '$frameHeight')
..setAttribute('width', '$frameWidth')
..setAttribute('rx', '15')
..setAttribute('ry', '15');
chart.append(frame);
}
2 changes: 1 addition & 1 deletion pkg/web_css/lib/src/_pkg.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@
margin-left: 10px;
}

.downloads-chart-frame {
.downloads-chart-axis-line {
fill:none;
stroke-width: 1;
stroke: var(--pub-downloads-chart-frame-color);
Expand Down