Skip to content

Conversation

@isoos
Copy link
Collaborator

@isoos isoos commented Feb 10, 2025

  • The session warning banner is displayed when the user session is close to expiry or was expired (on a page that may use the session cookies).
  • This warning banner was broken for a while now, probably because of the change in the disposable banners. Adjusting the z-index to create a temporary fix there.
  • The previous design had a yellow background, but I don't think we need that much color here, using the same background as the disposable banner use seems to be fine.
  • Long-term fix may involve migrating this banner to use the same template and widget location as the disposable banners.
image

--

image

@isoos isoos requested a review from jonasfj February 10, 2025 14:33
@isoos isoos merged commit 5ddc143 into dart-lang:master Feb 12, 2025
31 checks passed
@isoos isoos deleted the fix-session branch February 12, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants