Skip to content

Conversation

@isoos
Copy link
Collaborator

@isoos isoos commented Mar 13, 2025

  • Follow-up to TestProfile packages: explicit imported and generated fields. #8634.
  • The update-only mutability of TestPackage makes it harder to subclass it (especially if the TestVersion is also going to subclassed). Since we can infer the same default uploader from the TestProfile during import, there is no need to update it.
  • Note: I'm planning to also remove the versions update in a subsequent PR.

@isoos isoos requested review from jonasfj and sigurdm March 13, 2025 11:55
@isoos isoos merged commit e1fb48f into dart-lang:master Mar 13, 2025
31 checks passed
@isoos isoos deleted the normalizer-uploaders branch March 13, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants