Skip to content

Fix file opening in the retry loop of checking bytes. #8727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025
Merged

Fix file opening in the retry loop of checking bytes. #8727

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions app/lib/package/tarball_storage.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,10 +115,11 @@ class TarballStorage {
return ContentMatchStatus.different;
}
// Limit memory use while doing the byte-to-byte comparison by streaming it chunk-wise.
final raf = await file.open();
var remainingLength = info.length;
try {
await _canonicalBucket.readWithRetry(objectName, (input) async {
var remainingLength = -1;
await _canonicalBucket.readWithRetry(objectName, (input) async {
final raf = await file.open();
remainingLength = info.length;
try {
await for (final chunk in input) {
if (chunk.isEmpty) continue;
remainingLength -= chunk.length;
Expand All @@ -131,10 +132,10 @@ class TarballStorage {
return ContentMatchStatus.different;
}
}
});
} finally {
await raf.close();
}
} finally {
await raf.close();
}
});
if (remainingLength != 0) {
return ContentMatchStatus.different;
}
Expand Down