Skip to content

Remove SdkMemIndex.getLibraryDescription #8792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025
Merged

Remove SdkMemIndex.getLibraryDescription #8792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions app/lib/search/sdk_mem_index.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import 'dart:math';

import 'package:gcloud/service_scope.dart' as ss;
import 'package:logging/logging.dart';
import 'package:meta/meta.dart';
// ignore: implementation_imports
import 'package:pana/src/dartdoc/dartdoc_index.dart';
import 'package:path/path.dart' as p;
Expand Down Expand Up @@ -188,10 +187,6 @@ class SdkMemIndex {
))
.toList();
}

@visibleForTesting
String? getLibraryDescription(String library) =>
_libraries[library]?.description;
}

class _Hit {
Expand Down
3 changes: 2 additions & 1 deletion app/test/search/backend_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,9 @@ void main() {
dartIndex: DartdocIndex.parseJsonText(content),
flutterIndex: DartdocIndex([]),
);
final rs = index.search('dart:async');
expect(
index.getLibraryDescription('dart:async'),
rs.first.description,
'Support for asynchronous programming, with classes such as Future and Stream.',
);
});
Expand Down