Skip to content

Fix NPE in a task's dependency updated propagation. #8806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025
Merged

Fix NPE in a task's dependency updated propagation. #8806

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion app/lib/task/backend.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1327,8 +1327,13 @@ final class _TaskDataAccess {
return await withRetryTransaction(_db, (tx) async {
// Reload [state] within a transaction to avoid overwriting changes
// made by others trying to update state for another package.
final s = await tx.lookupValue<PackageState>(
final s = await tx.lookupOrNull<PackageState>(
PackageState.createKey(_db.emptyKey, runtimeVersion, package));
if (s == null) {
// No entry has been created yet, probably because of a new deployment rolling out.
// We can ignore it for now.
return false;
}
if (s.lastDependencyChanged!.isBefore(publishedAt)) {
tx.insert(
s
Expand Down