Skip to content

Render-blocking dark-theme initialization for dartdoc pages. #8837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2025
Merged

Render-blocking dark-theme initialization for dartdoc pages. #8837

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f94472f
Render-blocking dark-theme initialization for dartdoc pages.
isoos Jun 27, 2025
68cedd1
Remove special case for documentation and color-scheme preference.
isoos Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/lib/dartdoc/dartdoc_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,9 @@ extension DartDocPageRender on DartDocPage {
'width': '0',
'style': 'display:none;visibility:hidden',
})),
// NOTE: dartdoc's own initialization will still run, but it is not in conflict
// with the current script.
d.script(src: staticUrls.getAssetUrl('/static/js/dark-init.js')),
d.div(id: 'overlay-under-drawer'),
_renderHeader(options),
_renderMain(options),
Expand Down
8 changes: 8 additions & 0 deletions app/test/dartdoc/dartdoc_page_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,14 @@ void main() {
contains('https://www.googletagmanager.com/'));
firstNoScript.remove();

// removing extra dark-theme initializer script
renderedXmlDoc.descendantElements
.where((e) =>
e.localName == 'script' &&
e.getAttribute('src')!.endsWith('/dark-init.js'))
.single
.remove();

// removing extra logo
final firstLogo = renderedXmlDoc.descendantElements.firstWhere(
(e) =>
Expand Down
1 change: 1 addition & 0 deletions app/test/task/testdata/goldens/documentation/oxygen/1.0.0/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
</head>
<body class="light-theme" data-base-href="" data-using-base-href="false">
<noscript>&lt;iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MX6DBN9" height="0" width="0" style="display:none;visibility:hidden">&lt;/iframe></noscript>
<script src="/static/hash-%%etag%%/js/dark-init.js"></script>
<div id="overlay-under-drawer"></div>
<header id="title">
<span id="sidenav-left-toggle" class="material-symbols-outlined" role="button" tabindex="0">menu</span>
Expand Down
1 change: 1 addition & 0 deletions app/test/task/testdata/goldens/documentation/oxygen/1.0.0/oxygen/MainClass-class.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
</head>
<body class="light-theme" data-base-href="../" data-using-base-href="false">
<noscript>&lt;iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MX6DBN9" height="0" width="0" style="display:none;visibility:hidden">&lt;/iframe></noscript>
<script src="/static/hash-%%etag%%/js/dark-init.js"></script>
<div id="overlay-under-drawer"></div>
<header id="title">
<span id="sidenav-left-toggle" class="material-symbols-outlined" role="button" tabindex="0">menu</span>
Expand Down
1 change: 1 addition & 0 deletions app/test/task/testdata/goldens/documentation/oxygen/1.0.0/oxygen/MainClass/MainClass.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
</head>
<body class="light-theme" data-base-href="../../" data-using-base-href="false">
<noscript>&lt;iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MX6DBN9" height="0" width="0" style="display:none;visibility:hidden">&lt;/iframe></noscript>
<script src="/static/hash-%%etag%%/js/dark-init.js"></script>
<div id="overlay-under-drawer"></div>
<header id="title">
<span id="sidenav-left-toggle" class="material-symbols-outlined" role="button" tabindex="0">menu</span>
Expand Down
1 change: 1 addition & 0 deletions app/test/task/testdata/goldens/documentation/oxygen/1.0.0/oxygen/MainClass/text.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
</head>
<body class="light-theme" data-base-href="../../" data-using-base-href="false">
<noscript>&lt;iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MX6DBN9" height="0" width="0" style="display:none;visibility:hidden">&lt;/iframe></noscript>
<script src="/static/hash-%%etag%%/js/dark-init.js"></script>
<div id="overlay-under-drawer"></div>
<header id="title">
<span id="sidenav-left-toggle" class="material-symbols-outlined" role="button" tabindex="0">menu</span>
Expand Down
1 change: 1 addition & 0 deletions app/test/task/testdata/goldens/documentation/oxygen/1.0.0/oxygen/MainClass/toLowerCase.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
</head>
<body class="light-theme" data-base-href="../../" data-using-base-href="false">
<noscript>&lt;iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MX6DBN9" height="0" width="0" style="display:none;visibility:hidden">&lt;/iframe></noscript>
<script src="/static/hash-%%etag%%/js/dark-init.js"></script>
<div id="overlay-under-drawer"></div>
<header id="title">
<span id="sidenav-left-toggle" class="material-symbols-outlined" role="button" tabindex="0">menu</span>
Expand Down
1 change: 1 addition & 0 deletions app/test/task/testdata/goldens/documentation/oxygen/1.0.0/oxygen/MainClass/toString.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
</head>
<body class="light-theme" data-base-href="../../" data-using-base-href="false">
<noscript>&lt;iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MX6DBN9" height="0" width="0" style="display:none;visibility:hidden">&lt;/iframe></noscript>
<script src="/static/hash-%%etag%%/js/dark-init.js"></script>
<div id="overlay-under-drawer"></div>
<header id="title">
<span id="sidenav-left-toggle" class="material-symbols-outlined" role="button" tabindex="0">menu</span>
Expand Down
1 change: 1 addition & 0 deletions app/test/task/testdata/goldens/documentation/oxygen/1.0.0/oxygen/TypeEnum.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
</head>
<body class="light-theme" data-base-href="../" data-using-base-href="false">
<noscript>&lt;iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MX6DBN9" height="0" width="0" style="display:none;visibility:hidden">&lt;/iframe></noscript>
<script src="/static/hash-%%etag%%/js/dark-init.js"></script>
<div id="overlay-under-drawer"></div>
<header id="title">
<span id="sidenav-left-toggle" class="material-symbols-outlined" role="button" tabindex="0">menu</span>
Expand Down
1 change: 1 addition & 0 deletions ...est/task/testdata/goldens/documentation/oxygen/1.0.0/oxygen/TypeEnum/values-constant.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
</head>
<body class="light-theme" data-base-href="../../" data-using-base-href="false">
<noscript>&lt;iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MX6DBN9" height="0" width="0" style="display:none;visibility:hidden">&lt;/iframe></noscript>
<script src="/static/hash-%%etag%%/js/dark-init.js"></script>
<div id="overlay-under-drawer"></div>
<header id="title">
<span id="sidenav-left-toggle" class="material-symbols-outlined" role="button" tabindex="0">menu</span>
Expand Down
1 change: 1 addition & 0 deletions app/test/task/testdata/goldens/documentation/oxygen/1.0.0/oxygen/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
</head>
<body class="light-theme" data-base-href="../" data-using-base-href="false">
<noscript>&lt;iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MX6DBN9" height="0" width="0" style="display:none;visibility:hidden">&lt;/iframe></noscript>
<script src="/static/hash-%%etag%%/js/dark-init.js"></script>
<div id="overlay-under-drawer"></div>
<header id="title">
<span id="sidenav-left-toggle" class="material-symbols-outlined" role="button" tabindex="0">menu</span>
Expand Down
1 change: 1 addition & 0 deletions app/test/task/testdata/goldens/documentation/oxygen/1.0.0/oxygen/main.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
</head>
<body class="light-theme" data-base-href="../" data-using-base-href="false">
<noscript>&lt;iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MX6DBN9" height="0" width="0" style="display:none;visibility:hidden">&lt;/iframe></noscript>
<script src="/static/hash-%%etag%%/js/dark-init.js"></script>
<div id="overlay-under-drawer"></div>
<header id="title">
<span id="sidenav-left-toggle" class="material-symbols-outlined" role="button" tabindex="0">menu</span>
Expand Down
1 change: 1 addition & 0 deletions app/test/task/testdata/goldens/documentation/oxygen/2.0.0/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
</head>
<body class="light-theme" data-base-href="" data-using-base-href="false">
<noscript>&lt;iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MX6DBN9" height="0" width="0" style="display:none;visibility:hidden">&lt;/iframe></noscript>
<script src="/static/hash-%%etag%%/js/dark-init.js"></script>
<div id="overlay-under-drawer"></div>
<header id="title">
<span id="sidenav-left-toggle" class="material-symbols-outlined" role="button" tabindex="0">menu</span>
Expand Down
1 change: 1 addition & 0 deletions app/test/task/testdata/goldens/documentation/oxygen/2.0.0/oxygen/MainClass-class.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
</head>
<body class="light-theme" data-base-href="../" data-using-base-href="false">
<noscript>&lt;iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MX6DBN9" height="0" width="0" style="display:none;visibility:hidden">&lt;/iframe></noscript>
<script src="/static/hash-%%etag%%/js/dark-init.js"></script>
<div id="overlay-under-drawer"></div>
<header id="title">
<span id="sidenav-left-toggle" class="material-symbols-outlined" role="button" tabindex="0">menu</span>
Expand Down
1 change: 1 addition & 0 deletions app/test/task/testdata/goldens/documentation/oxygen/2.0.0/oxygen/MainClass/MainClass.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
</head>
<body class="light-theme" data-base-href="../../" data-using-base-href="false">
<noscript>&lt;iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MX6DBN9" height="0" width="0" style="display:none;visibility:hidden">&lt;/iframe></noscript>
<script src="/static/hash-%%etag%%/js/dark-init.js"></script>
<div id="overlay-under-drawer"></div>
<header id="title">
<span id="sidenav-left-toggle" class="material-symbols-outlined" role="button" tabindex="0">menu</span>
Expand Down
1 change: 1 addition & 0 deletions app/test/task/testdata/goldens/documentation/oxygen/2.0.0/oxygen/MainClass/text.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
</head>
<body class="light-theme" data-base-href="../../" data-using-base-href="false">
<noscript>&lt;iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MX6DBN9" height="0" width="0" style="display:none;visibility:hidden">&lt;/iframe></noscript>
<script src="/static/hash-%%etag%%/js/dark-init.js"></script>
<div id="overlay-under-drawer"></div>
<header id="title">
<span id="sidenav-left-toggle" class="material-symbols-outlined" role="button" tabindex="0">menu</span>
Expand Down
1 change: 1 addition & 0 deletions app/test/task/testdata/goldens/documentation/oxygen/2.0.0/oxygen/MainClass/toLowerCase.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
</head>
<body class="light-theme" data-base-href="../../" data-using-base-href="false">
<noscript>&lt;iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MX6DBN9" height="0" width="0" style="display:none;visibility:hidden">&lt;/iframe></noscript>
<script src="/static/hash-%%etag%%/js/dark-init.js"></script>
<div id="overlay-under-drawer"></div>
<header id="title">
<span id="sidenav-left-toggle" class="material-symbols-outlined" role="button" tabindex="0">menu</span>
Expand Down
1 change: 1 addition & 0 deletions app/test/task/testdata/goldens/documentation/oxygen/2.0.0/oxygen/MainClass/toString.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
</head>
<body class="light-theme" data-base-href="../../" data-using-base-href="false">
<noscript>&lt;iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MX6DBN9" height="0" width="0" style="display:none;visibility:hidden">&lt;/iframe></noscript>
<script src="/static/hash-%%etag%%/js/dark-init.js"></script>
<div id="overlay-under-drawer"></div>
<header id="title">
<span id="sidenav-left-toggle" class="material-symbols-outlined" role="button" tabindex="0">menu</span>
Expand Down
1 change: 1 addition & 0 deletions app/test/task/testdata/goldens/documentation/oxygen/2.0.0/oxygen/TypeEnum.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
</head>
<body class="light-theme" data-base-href="../" data-using-base-href="false">
<noscript>&lt;iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MX6DBN9" height="0" width="0" style="display:none;visibility:hidden">&lt;/iframe></noscript>
<script src="/static/hash-%%etag%%/js/dark-init.js"></script>
<div id="overlay-under-drawer"></div>
<header id="title">
<span id="sidenav-left-toggle" class="material-symbols-outlined" role="button" tabindex="0">menu</span>
Expand Down
1 change: 1 addition & 0 deletions ...est/task/testdata/goldens/documentation/oxygen/2.0.0/oxygen/TypeEnum/values-constant.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
</head>
<body class="light-theme" data-base-href="../../" data-using-base-href="false">
<noscript>&lt;iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MX6DBN9" height="0" width="0" style="display:none;visibility:hidden">&lt;/iframe></noscript>
<script src="/static/hash-%%etag%%/js/dark-init.js"></script>
<div id="overlay-under-drawer"></div>
<header id="title">
<span id="sidenav-left-toggle" class="material-symbols-outlined" role="button" tabindex="0">menu</span>
Expand Down
1 change: 1 addition & 0 deletions app/test/task/testdata/goldens/documentation/oxygen/2.0.0/oxygen/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
</head>
<body class="light-theme" data-base-href="../" data-using-base-href="false">
<noscript>&lt;iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MX6DBN9" height="0" width="0" style="display:none;visibility:hidden">&lt;/iframe></noscript>
<script src="/static/hash-%%etag%%/js/dark-init.js"></script>
<div id="overlay-under-drawer"></div>
<header id="title">
<span id="sidenav-left-toggle" class="material-symbols-outlined" role="button" tabindex="0">menu</span>
Expand Down
1 change: 1 addition & 0 deletions app/test/task/testdata/goldens/documentation/oxygen/2.0.0/oxygen/main.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
</head>
<body class="light-theme" data-base-href="../" data-using-base-href="false">
<noscript>&lt;iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MX6DBN9" height="0" width="0" style="display:none;visibility:hidden">&lt;/iframe></noscript>
<script src="/static/hash-%%etag%%/js/dark-init.js"></script>
<div id="overlay-under-drawer"></div>
<header id="title">
<span id="sidenav-left-toggle" class="material-symbols-outlined" role="button" tabindex="0">menu</span>
Expand Down
1 change: 1 addition & 0 deletions app/test/task/testdata/goldens/documentation/oxygen/latest/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
</head>
<body class="light-theme" data-base-href="" data-using-base-href="false">
<noscript>&lt;iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MX6DBN9" height="0" width="0" style="display:none;visibility:hidden">&lt;/iframe></noscript>
<script src="/static/hash-%%etag%%/js/dark-init.js"></script>
<div id="overlay-under-drawer"></div>
<header id="title">
<span id="sidenav-left-toggle" class="material-symbols-outlined" role="button" tabindex="0">menu</span>
Expand Down
1 change: 1 addition & 0 deletions app/test/task/testdata/goldens/documentation/oxygen/latest/oxygen/MainClass-class.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
</head>
<body class="light-theme" data-base-href="../" data-using-base-href="false">
<noscript>&lt;iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MX6DBN9" height="0" width="0" style="display:none;visibility:hidden">&lt;/iframe></noscript>
<script src="/static/hash-%%etag%%/js/dark-init.js"></script>
<div id="overlay-under-drawer"></div>
<header id="title">
<span id="sidenav-left-toggle" class="material-symbols-outlined" role="button" tabindex="0">menu</span>
Expand Down
1 change: 1 addition & 0 deletions app/test/task/testdata/goldens/documentation/oxygen/latest/oxygen/MainClass/MainClass.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
</head>
<body class="light-theme" data-base-href="../../" data-using-base-href="false">
<noscript>&lt;iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MX6DBN9" height="0" width="0" style="display:none;visibility:hidden">&lt;/iframe></noscript>
<script src="/static/hash-%%etag%%/js/dark-init.js"></script>
<div id="overlay-under-drawer"></div>
<header id="title">
<span id="sidenav-left-toggle" class="material-symbols-outlined" role="button" tabindex="0">menu</span>
Expand Down
1 change: 1 addition & 0 deletions app/test/task/testdata/goldens/documentation/oxygen/latest/oxygen/MainClass/text.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
</head>
<body class="light-theme" data-base-href="../../" data-using-base-href="false">
<noscript>&lt;iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MX6DBN9" height="0" width="0" style="display:none;visibility:hidden">&lt;/iframe></noscript>
<script src="/static/hash-%%etag%%/js/dark-init.js"></script>
<div id="overlay-under-drawer"></div>
<header id="title">
<span id="sidenav-left-toggle" class="material-symbols-outlined" role="button" tabindex="0">menu</span>
Expand Down
1 change: 1 addition & 0 deletions app/test/task/testdata/goldens/documentation/oxygen/latest/oxygen/MainClass/toLowerCase.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
</head>
<body class="light-theme" data-base-href="../../" data-using-base-href="false">
<noscript>&lt;iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MX6DBN9" height="0" width="0" style="display:none;visibility:hidden">&lt;/iframe></noscript>
<script src="/static/hash-%%etag%%/js/dark-init.js"></script>
<div id="overlay-under-drawer"></div>
<header id="title">
<span id="sidenav-left-toggle" class="material-symbols-outlined" role="button" tabindex="0">menu</span>
Expand Down
1 change: 1 addition & 0 deletions app/test/task/testdata/goldens/documentation/oxygen/latest/oxygen/MainClass/toString.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
</head>
<body class="light-theme" data-base-href="../../" data-using-base-href="false">
<noscript>&lt;iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MX6DBN9" height="0" width="0" style="display:none;visibility:hidden">&lt;/iframe></noscript>
<script src="/static/hash-%%etag%%/js/dark-init.js"></script>
<div id="overlay-under-drawer"></div>
<header id="title">
<span id="sidenav-left-toggle" class="material-symbols-outlined" role="button" tabindex="0">menu</span>
Expand Down
1 change: 1 addition & 0 deletions app/test/task/testdata/goldens/documentation/oxygen/latest/oxygen/TypeEnum.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
</head>
<body class="light-theme" data-base-href="../" data-using-base-href="false">
<noscript>&lt;iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MX6DBN9" height="0" width="0" style="display:none;visibility:hidden">&lt;/iframe></noscript>
<script src="/static/hash-%%etag%%/js/dark-init.js"></script>
<div id="overlay-under-drawer"></div>
<header id="title">
<span id="sidenav-left-toggle" class="material-symbols-outlined" role="button" tabindex="0">menu</span>
Expand Down
1 change: 1 addition & 0 deletions ...st/task/testdata/goldens/documentation/oxygen/latest/oxygen/TypeEnum/values-constant.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
</head>
<body class="light-theme" data-base-href="../../" data-using-base-href="false">
<noscript>&lt;iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MX6DBN9" height="0" width="0" style="display:none;visibility:hidden">&lt;/iframe></noscript>
<script src="/static/hash-%%etag%%/js/dark-init.js"></script>
<div id="overlay-under-drawer"></div>
<header id="title">
<span id="sidenav-left-toggle" class="material-symbols-outlined" role="button" tabindex="0">menu</span>
Expand Down
1 change: 1 addition & 0 deletions app/test/task/testdata/goldens/documentation/oxygen/latest/oxygen/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
</head>
<body class="light-theme" data-base-href="../" data-using-base-href="false">
<noscript>&lt;iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MX6DBN9" height="0" width="0" style="display:none;visibility:hidden">&lt;/iframe></noscript>
<script src="/static/hash-%%etag%%/js/dark-init.js"></script>
<div id="overlay-under-drawer"></div>
<header id="title">
<span id="sidenav-left-toggle" class="material-symbols-outlined" role="button" tabindex="0">menu</span>
Expand Down
1 change: 1 addition & 0 deletions app/test/task/testdata/goldens/documentation/oxygen/latest/oxygen/main.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
</head>
<body class="light-theme" data-base-href="../" data-using-base-href="false">
<noscript>&lt;iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MX6DBN9" height="0" width="0" style="display:none;visibility:hidden">&lt;/iframe></noscript>
<script src="/static/hash-%%etag%%/js/dark-init.js"></script>
<div id="overlay-under-drawer"></div>
<header id="title">
<span id="sidenav-left-toggle" class="material-symbols-outlined" role="button" tabindex="0">menu</span>
Expand Down
7 changes: 7 additions & 0 deletions static/js/dark-init.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,13 @@
// ignore errors e.g. when media query matching is not supported
}

// NOTE: dartdoc currently does not support externally supported color scheme,
// and we disable that part for the affected URLs.
// TODO: remove this part when dartdoc supports the above detection too
if (window.location.pathname.startsWith('/documentation/')) {
mediaPrefersDarkScheme = false;
}

// Detects whether the control widget was set to use a specific theme
let colorTheme = window.localStorage.getItem('colorTheme');
let lightThemeIsSet = colorTheme == 'false';
Expand Down