Skip to content

Strip some of the license coverage data if the report would be over the size limit. #8979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2025
Merged

Strip some of the license coverage data if the report would be over the size limit. #8979

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion pkg/pub_worker/lib/src/bin/pana_wrapper.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,31 @@ Future<void> main(List<String> args) async {
);

// sanity check on pana report size
final reportSize = gzip
var reportSize = gzip
.encode(utf8.encode(json.encode(summary.toJson())))
.length;

// Note: the new license coverage data seems to generate coverage pairs that
// occupy way too much space. Until that bug is fixed, we should remove
// that data from the summary.
// TODO: remove this block once https://github.com/dart-lang/pana/issues/1481 gets fixed and deployed
if (reportSize > _reportSizeDropThreshold) {
// We are storing the licenses in two fields, removing the fallback/unused one.
// ignore: deprecated_member_use
summary.licenses?.clear();

// Remove excessive range data.
for (final l in summary.result?.licenses ?? <License>[]) {
final count = l.range?.coverages.length ?? 0;
if (count > 50) {
l.range?.coverages.removeRange(50, count);
}
}

// re-calculate report size
reportSize = gzip.encode(utf8.encode(json.encode(summary.toJson()))).length;
}

if (reportSize > _reportSizeDropThreshold) {
summary = Summary(
createdAt: summary.createdAt,
Expand Down