Image proxy Add security headers to all responses #9026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isoos
reviewed
Oct 21, 2025
| return shelf.Response.notFound('Unsupported method'); | ||
| return shelf.Response.notFound( | ||
| 'Unsupported method', | ||
| headers: {...securityHeaders}, |
Collaborator
There was a problem hiding this comment.
I think we can write headers: securityHeaders here (and later on), since it won't update the headers map. (maybe make it const to be sure)
Collaborator
There was a problem hiding this comment.
missing push on the commit?
isoos
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.