Skip to content

Conversation

@isoos
Copy link
Collaborator

@isoos isoos commented Nov 7, 2025

During the local test_profile import I've encountered the following strange issue:

FINE: Created /home/isoos/work/tmp/pub-cache/_temp/dirLXTOFI/test from stream.
IO  : Deleting directory pub-cache/_temp/dirLXTOFI.
IO  : Deleting directory /home/isoos/work/tmp/pub_CEOGVT.
FINE: Downloading lua 0.2.0 to `target/lua-0.2.0` finished (0.070s).
ERR : Creation failed, path = '/home/isoos/work/tmp/pub-cache/_temp/dirLXTOFI/test' (OS Error: Not a directory, errno = 20)

Tracked down to the test_profile importer code where we wanted to enforce certain file permissions, which were working for older archives, but recent archives seems to have additional flags. And for some reason the tar archive now has entries for directories, which we have re-created as files. (Note: this is only in the scope of local test_profile importing a recent archive, does not affect the pub site.)

Also updated the archive builder to not create a merged bytes blob unless it is needed (should give a little bit better test latencies).

@isoos isoos requested a review from sigurdm November 7, 2025 09:42
@sigurdm
Copy link
Contributor

sigurdm commented Nov 7, 2025

Yeah, at some point we updated the client to include directories in the tarballs, and also we fixed some permission issue with directories:
dart-lang/pub#4283
dart-lang/pub#4306

@isoos isoos merged commit 67c0600 into dart-lang:master Nov 7, 2025
24 checks passed
@isoos isoos deleted the fix-import branch November 7, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants