Skip to content

Commit 066efcf

Browse files
mkustermannCommit Queue
authored andcommitted
[dart2wasm] Remove JSC bug workaround
JavaScriptCore's wasm interpreter was buggy which caused many segfaults on our CI, which made us implement this workaround (namely to disable the wasm interpreter) It seems it has matured, so we can remove this workaround. Doing so may also lead to less jsc crashes / instability on CI and will make us use default flags (testing closer to what is used in real Safari) Change-Id: Id30a017dcf1b3b37e6c0c99bddfa634b96bf45ac Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/458100 Reviewed-by: Nate Biggs <[email protected]> Commit-Queue: Martin Kustermann <[email protected]>
1 parent 822450b commit 066efcf

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

pkg/test_runner/lib/src/runtime_configuration.dart

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -244,13 +244,9 @@ class JSCRuntimeConfiguration extends CommandLineJavaScriptRuntime {
244244
if (compiler != Compiler.dart2wasm) {
245245
throw 'No test runner setup for jsc + dart2js yet';
246246
}
247-
// TODO(https://bugs.webkit.org/show_bug.cgi?id=285902): Once the
248-
// JavaScriptCore/WebKit bug is fixed we should be able to remove this
249-
// again.
250-
const jscBugWorkaround = '--shell-option=--useWasmIPInt=false';
251247
return [
252248
Dart2WasmCommandLineCommand(moniker, 'pkg/dart2wasm/tool/run_benchmark',
253-
['--jsc', jscBugWorkaround, ...arguments], environmentOverrides)
249+
['--jsc', ...arguments], environmentOverrides)
254250
];
255251
}
256252
}

0 commit comments

Comments
 (0)