[DAS] Fixes DartEditBuilder.writeType to handle private typedefs correctly

Fixes: #61838
Change-Id: Ic5e73241bfdb3210d5d2d43ea6136a8d948f2e13
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/457883
Auto-Submit: Felipe Morschel <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>

Author: FMorschel

pkg/analysis_server/test/src/services/correction/fix/create_getter_test.dart

@@ -710,6 +710,102 @@ class A {
 ''', target: part1Path);
   }
 
+  Future<void> test_privateAlias() async {
+    newFile(join(testPackageLibPath, 'a.dart'), '''
+class A {
+}
+''');
+    await resolveTestCode('''
+import 'a.dart';
+typedef _F = int Function(int v);
+void f(A a) {
+  _F v = a.test;
+  print(v);
+}
+''');
+    await assertHasFix('''
+class A {
+  int Function(int v) get test => null;
+}
+''', target: join(testPackageLibPath, 'a.dart'));
+  }
+
+  Future<void> test_privateAlias_2() async {
+    newFile(join(testPackageLibPath, 'a.dart'), '''
+typedef _F = int Function(int v);
+class A {
+  set test(_F f) {}
+}
+''');
+    await resolveTestCode('''
+import 'a.dart';
+class C {
+  void m(A a) {
+    a.test = test;
+  }
+}
+''');
+    await assertHasFix('''
+import 'a.dart';
+class C {
+  int Function(int v) get test => null;
+
+  void m(A a) {
+    a.test = test;
+  }
+}
+''');
+  }
+
+  Future<void> test_privateType_privateAlias() async {
+    newFile(join(testPackageLibPath, 'a.dart'), '''
+class A {
+}
+''');
+    await resolveTestCode('''
+import 'a.dart';
+class _C {}
+typedef _T = _C;
+void f(A a) {
+  _T v = a.test;
+  print(v);
+}
+''');
+    await assertHasFix('''
+class A {
+  Object get test => null;
+}
+''', target: join(testPackageLibPath, 'a.dart'));
+  }
+
+  Future<void> test_privateType_privateAlias_2() async {
+    newFile(join(testPackageLibPath, 'a.dart'), '''
+class _C {}
+typedef _T = _C;
+class A {
+  set test(_T t) {}
+}
+''');
+    await resolveTestCode('''
+import 'a.dart';
+class C {
+  void m(A a) {
+    a.test = test;
+  }
+}
+''');
+    await assertHasFix('''
+import 'a.dart';
+class C {
+  Object get test => null;
+
+  void m(A a) {
+    a.test = test;
+  }
+}
+''');
+  }
+
   Future<void> test_qualified_instance() async {
     await resolveTestCode('''
 class A {

pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart

@@ -1123,7 +1123,10 @@ class DartEditBuilderImpl extends EditBuilderImpl implements DartEditBuilder {
     }
 
     var alias = type.alias;
-    if (alias != null) {
+    if (alias != null &&
+        alias.element.isAccessibleIn(
+          _dartFileEditBuilder.resolvedLibrary.element,
+        )) {
       return true;
     }
 
@@ -1543,7 +1546,10 @@ class DartEditBuilderImpl extends EditBuilderImpl implements DartEditBuilder {
     }
 
     var alias = type.alias;
-    if (alias != null) {
+    if (alias != null &&
+        alias.element.isAccessibleIn(
+          _dartFileEditBuilder.resolvedLibrary.element,
+        )) {
       _writeTypeElementArguments(
         element: alias.element,
         typeArguments: alias.typeArguments,