Skip to content

Commit 1c429e9

Browse files
alexmarkovCommit Queue
alexmarkov
authored and
Commit Queue
committed
[dynamic modules] Add dart:core to dynamic interface by default
In order to simplify creating dynamic interface yaml files, the following is added to dynamic interface by default: callable: dart:core, pragma._ extendable: Object TEST=pkg/dynamic_modules/test CoreLibraryReviewExempt: no API changes, only adding pragmas Change-Id: I925532c4c024ebbcf4972b00be0e0a080d5878fa Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/422024 Reviewed-by: Sigmund Cherem <[email protected]> Commit-Queue: Alexander Markov <[email protected]>
1 parent 23c8a11 commit 1c429e9

File tree

30 files changed

+17
-324
lines changed

30 files changed

+17
-324
lines changed

‎pkg/dynamic_modules/test/data/apply_mixin/dynamic_interface.yaml‎

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -6,23 +6,8 @@ extendable:
66
class: 'A'
77
- library: 'shared/shared.dart'
88
class: 'M'
9-
# TODO(sigmund): This should be included by default
10-
- library: 'dart:core'
11-
class: 'Object'
129

1310
callable:
14-
# TODO(sigmund): This should be included by default
15-
- library: 'dart:core'
16-
class: 'Object'
17-
- library: 'dart:core'
18-
class: 'int'
19-
- library: 'dart:core'
20-
class: 'String'
21-
- library: 'dart:core'
22-
class: 'pragma'
23-
member: '_'
24-
- library: 'dart:core'
25-
member: 'override'
2611
- library: 'shared/shared.dart'
2712
class: 'M'
2813

‎pkg/dynamic_modules/test/data/closure_invocation/dynamic_interface.yaml‎

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,3 @@
33
# BSD-style license that can be found in the LICENSE file.
44
callable:
55
- library: 'shared/shared.dart'
6-
# TODO(sigmund): This should be included by default
7-
- library: 'dart:core'
8-
class: 'pragma'
9-
member: '_'
10-
- library: 'dart:core'
11-
class: 'Object'
12-
- library: 'dart:core'
13-
class: 'int'
14-
- library: 'dart:core'
15-
class: 'String'
16-

‎pkg/dynamic_modules/test/data/const_body/dynamic_interface.yaml‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,3 @@ callable:
66
- library: 'shared/shared.dart'
77
class: 'B'
88
member: ''
9-
# TODO(sigmund): This should be included by default
10-
- library: 'dart:core'
11-
class: 'Object'
12-
- library: 'dart:core'
13-
class: 'pragma'
14-
member: '_'

‎pkg/dynamic_modules/test/data/core_api/dynamic_interface.yaml‎

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -2,34 +2,6 @@
22
# for details. All rights reserved. Use of this source code is governed by a
33
# BSD-style license that can be found in the LICENSE file.
44
callable:
5-
# Mentioned in the code, however core types should be included by default
65
- library: 'package:expect/expect.dart'
76
class: 'Expect'
87
member: 'equals'
9-
- library: 'dart:async'
10-
class: 'Future'
11-
- library: 'dart:core'
12-
class: 'String'
13-
- library: 'dart:core'
14-
class: 'int'
15-
- library: 'dart:core'
16-
class: 'bool'
17-
- library: 'dart:core'
18-
class: 'List'
19-
- library: 'dart:core'
20-
class: 'Iterable'
21-
22-
# TODO(sigmund): This should be included by default
23-
- library: 'dart:core'
24-
class: 'pragma'
25-
member: '_'
26-
27-
# Needed to support for-in loops
28-
- library: 'dart:core'
29-
class: 'Iterator'
30-
member: 'moveNext'
31-
- library: 'dart:core'
32-
class: 'Iterator'
33-
member: 'get:current'
34-
- library: 'dart:core'
35-
class: 'Iterator'

‎pkg/dynamic_modules/test/data/duplicate_library/dynamic_interface.yaml‎

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,3 @@
22
# for details. All rights reserved. Use of this source code is governed by a
33
# BSD-style license that can be found in the LICENSE file.
44

5-
extendable:
6-
# TODO(sigmund): This should be included by default
7-
- library: 'dart:core'
8-
class: 'Object'
9-
10-
callable:
11-
# TODO(sigmund): This should be included by default
12-
- library: 'dart:core'
13-
class: 'Object'
14-
- library: 'dart:core'
15-
class: 'pragma'
16-
member: '_'

‎pkg/dynamic_modules/test/data/dyn_module_type_checks/dynamic_interface.yaml‎

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,3 @@ callable:
2020
- library: 'shared/shared.dart'
2121
class: 'Base'
2222
member: 'method1'
23-
# TODO(sigmund): This should be included by default
24-
- library: 'dart:core'
25-
class: 'Object'
26-
- library: 'dart:core'
27-
class: 'int'
28-
- library: 'dart:core'
29-
class: 'pragma'
30-
member: '_'
31-
- library: 'dart:core'
32-
member: 'override'
33-
- library: 'dart:core'
34-
class: 'num'

‎pkg/dynamic_modules/test/data/enum/dynamic_interface.yaml‎

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,3 @@
22
# for details. All rights reserved. Use of this source code is governed by a
33
# BSD-style license that can be found in the LICENSE file.
44

5-
callable:
6-
# TODO(sigmund): This should be included by default
7-
- library: 'dart:core'
8-
class: 'Object'
9-
- library: 'dart:core'
10-
class: 'String'
11-
- library: 'dart:core'
12-
class: 'int'
13-
- library: 'dart:core'
14-
class: 'List'
15-
- library: 'dart:core'
16-
class: 'pragma'
17-
member: '_'

‎pkg/dynamic_modules/test/data/extend_class/dynamic_interface.yaml‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,3 @@ callable:
1515
- library: 'shared/shared.dart'
1616
class: 'Base'
1717
member: ''
18-
# TODO(sigmund): This should be included by default
19-
- library: 'dart:core'
20-
class: 'Object'
21-
- library: 'dart:core'
22-
class: 'int'
23-
- library: 'dart:core'
24-
class: 'pragma'
25-
member: '_'
26-
- library: 'dart:core'
27-
member: 'override'

‎pkg/dynamic_modules/test/data/extend_class2/dynamic_interface.yaml‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,3 @@ callable:
1515
- library: 'shared/shared.dart'
1616
class: 'Base'
1717
member: ''
18-
# TODO(sigmund): This should be included by default
19-
- library: 'dart:core'
20-
class: 'Object'
21-
- library: 'dart:core'
22-
class: 'int'
23-
- library: 'dart:core'
24-
class: 'pragma'
25-
member: '_'
26-
- library: 'dart:core'
27-
member: 'override'

‎pkg/dynamic_modules/test/data/extend_class_dyn_only/dynamic_interface.yaml‎

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,3 @@
11
# Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
22
# for details. All rights reserved. Use of this source code is governed by a
33
# BSD-style license that can be found in the LICENSE file.
4-
5-
callable:
6-
- library: 'dart:core'
7-
class: 'Object'
8-
- library: 'dart:core'
9-
class: 'int'
10-
- library: 'dart:core'
11-
class: 'pragma'
12-
member: '_'
13-
- library: 'dart:core'
14-
member: 'override'
15-
- library: 'dart:core'
16-
class: 'bool'
17-
- library: 'dart:core'
18-
class: 'num'
19-
20-
extendable:
21-
- library: 'dart:core'
22-
class: 'Object'
23-

0 commit comments

Comments
 (0)