Elements. Remove V1 getters from FunctionType.

Change-Id: Ic1d3b2d64c4b6b647c9134263d77479bf88b16c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/423365
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analyzer/api.txt

@@ -4155,12 +4155,7 @@ package:analyzer/dart/element/type.dart:
     namedParameterTypes (getter: Map<String, DartType>)
     normalParameterTypes (getter: List<DartType>)
     optionalParameterTypes (getter: List<DartType>)
-    parameters (getter: List<ParameterElement>, deprecated)
-    positionalParameterTypes (getter: List<DartType>, deprecated)
-    requiredPositionalParameterCount (getter: int, deprecated)
     returnType (getter: DartType)
-    sortedNamedParameters (getter: List<ParameterElement>, deprecated)
-    typeFormals (getter: List<TypeParameterElement>, deprecated)
     typeParameters (getter: List<TypeParameterElement2>, experimental)
     instantiate (method: FunctionType Function(List<DartType>))
   InstantiatedTypeAliasElement (class extends Object):

pkg/analyzer/lib/dart/element/type.dart

@@ -21,7 +21,6 @@
 /// the references to `String` and `int` are type arguments.
 library;
 
-import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/dart/element/element2.dart';
 import 'package:analyzer/dart/element/nullability_suffix.dart';
 import 'package:analyzer/dart/element/type_visitor.dart';
@@ -244,50 +243,9 @@ abstract class FunctionType implements DartType {
   /// optional parameters declared, then the map is empty.
   List<DartType> get optionalParameterTypes;
 
-  /// A list containing the parameters elements of this type of function.
-  ///
-  /// The parameter types are not necessarily in the same order as they appear
-  /// in the declaration of the function.
-  @Deprecated('Use formalParameters instead')
-  List<ParameterElement> get parameters;
-
-  /// All the positional parameter types, starting with the required ones, and
-  /// followed by the optional ones.
-  ///
-  /// Deprecated: this getter is a part of the analyzer's private
-  /// implementation, and was exposed by accident (see
-  /// https://github.com/dart-lang/sdk/issues/59763). Please use
-  /// [normalParameterTypes] and [optionalParameterTypes] instead.
-  @Deprecated('Please use normalParameterTypes and optionalParameterTypes')
-  List<DartType> get positionalParameterTypes;
-
-  /// The number of elements of [positionalParameterTypes] that are required
-  /// parameters.
-  ///
-  /// Deprecated: this getter is a part of the analyzer's private
-  /// implementation, and was exposed by accident (see
-  /// https://github.com/dart-lang/sdk/issues/59763). Please use
-  /// [normalParameterTypes].length instead.
-  @Deprecated('Please use normalParameterTypes.length')
-  int get requiredPositionalParameterCount;
-
   /// The type of object returned by this type of function.
   DartType get returnType;
 
-  /// All the named parameters, sorted by name.
-  ///
-  /// Deprecated: this getter is a part of the analyzer's private
-  /// implementation, and was exposed by accident (see
-  /// https://github.com/dart-lang/sdk/issues/59763). Please use [parameters]
-  /// instead.
-  @Deprecated('Please use parameters')
-  List<ParameterElement> get sortedNamedParameters;
-
-  /// The formal type parameters of this generic function; for example,
-  /// `<T> T -> T`.
-  @Deprecated('Use typeParameters instead')
-  List<TypeParameterElement> get typeFormals;
-
   /// The type parameters.
   @experimental
   List<TypeParameterElement2> get typeParameters;

pkg/analyzer/lib/src/dart/element/type.dart

@@ -88,22 +88,37 @@ class FunctionTypeImpl extends TypeImpl
   @override
   final TypeImpl returnType;
 
-  @override
+  /// The formal type parameters of this generic function; for example,
+  /// `<T> T -> T`.
   final List<TypeParameterElementImpl> typeFormals;
 
-  @override
+  /// A list containing the parameters elements of this type of function.
+  ///
+  /// The parameter types are not necessarily in the same order as they appear
+  /// in the declaration of the function.
   final List<ParameterElementMixin> parameters;
 
   @override
   final NullabilitySuffix nullabilitySuffix;
 
-  @override
+  /// All the positional parameter types, starting with the required ones, and
+  /// followed by the optional ones.
+  ///
+  /// Deprecated: this getter is a part of the analyzer's private
+  /// implementation, and was exposed by accident (see
+  /// https://github.com/dart-lang/sdk/issues/59763). Please use
+  /// [normalParameterTypes] and [optionalParameterTypes] instead.
   final List<TypeImpl> positionalParameterTypes;
 
   @override
   final int requiredPositionalParameterCount;
 
-  @override
+  /// All the named parameters, sorted by name.
+  ///
+  /// Deprecated: this getter is a part of the analyzer's private
+  /// implementation, and was exposed by accident (see
+  /// https://github.com/dart-lang/sdk/issues/59763). Please use [parameters]
+  /// instead.
   final List<ParameterElementMixin> sortedNamedParameters;
 
   factory FunctionTypeImpl({