analyzer: Use DiagnosticCode instead of ErrorCode in tests

Change-Id: I6b70bda2e678777efdfde7c0cb9dca4ec85b27e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425686
Commit-Queue: Samuel Rawlins <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>

Author: srawlins

pkg/analyzer/lib/error/listener.dart

@@ -90,19 +90,19 @@ class ErrorReporter {
     }
   }
 
-  /// Report an error with the given [errorCode] and [arguments].
+  /// Report an error with the given [diagnosticCode] and [arguments].
   /// The [element] is used to compute the location of the error.
   @experimental
   void atElement2(
     Element element2,
-    ErrorCode errorCode, {
+    ErrorCode diagnosticCode, {
     List<Object>? arguments,
     List<DiagnosticMessage>? contextMessages,
     Object? data,
   }) {
     var nonSynthetic = element2.nonSynthetic2;
     atOffset(
-      errorCode: errorCode,
+      errorCode: diagnosticCode,
       offset: nonSynthetic.firstFragment.nameOffset2 ?? -1,
       length: nonSynthetic.name3?.length ?? 0,
       arguments: arguments,
@@ -130,17 +130,17 @@ class ErrorReporter {
     );
   }
 
-  /// Report an error with the given [errorCode] and [arguments].
+  /// Report an error with the given [diagnosticCode] and [arguments].
   /// The [node] is used to compute the location of the error.
   void atNode(
     AstNode node,
-    ErrorCode errorCode, {
+    ErrorCode diagnosticCode, {
     List<Object>? arguments,
     List<DiagnosticMessage>? contextMessages,
     Object? data,
   }) {
     atOffset(
-      errorCode: errorCode,
+      errorCode: diagnosticCode,
       offset: node.offset,
       length: node.length,
       arguments: arguments,
@@ -213,17 +213,17 @@ class ErrorReporter {
     );
   }
 
-  /// Report an error with the given [errorCode] and [arguments]. The [token] is
+  /// Report an error with the given [diagnosticCode] and [arguments]. The [token] is
   /// used to compute the location of the error.
   void atToken(
     Token token,
-    ErrorCode errorCode, {
+    ErrorCode diagnosticCode, {
     List<Object>? arguments,
     List<DiagnosticMessage>? contextMessages,
     Object? data,
   }) {
     atOffset(
-      errorCode: errorCode,
+      errorCode: diagnosticCode,
       offset: token.offset,
       length: token.length,
       arguments: arguments,

pkg/analyzer/test/generated/collection_literal_parser_test.dart

@@ -20,7 +20,7 @@ main() {
 class CollectionLiteralParserTest extends FastaParserTestCase {
   Expression parseCollectionLiteral(
     String source, {
-    List<ErrorCode>? codes,
+    List<DiagnosticCode>? codes,
     List<ExpectedError>? errors,
     int? expectedEndOffset,
     bool inAsync = false,

pkg/analyzer/test/generated/complex_parser_test.dart

@@ -593,10 +593,9 @@ void f() {
 
   void _validate_assignableExpression_arguments_normal_chain_typeArguments(
     String code, [
-    List<ErrorCode> errorCodes = const <ErrorCode>[],
+    List<DiagnosticCode> codes = const <DiagnosticCode>[],
   ]) {
-    var propertyAccess1 =
-        parseExpression(code, codes: errorCodes) as PropertyAccess;
+    var propertyAccess1 = parseExpression(code, codes: codes) as PropertyAccess;
     expect(propertyAccess1.propertyName.name, "f");
     //
     // a<E>(b)<F>(c).d<G>(e)

pkg/analyzer/test/generated/formal_parameter_parser_test.dart

@@ -1065,7 +1065,7 @@ class C {
   void test_parseNormalFormalParameter_field_const_noType() {
     NormalFormalParameter parameter = parseNormalFormalParameter(
       'const this.a',
-      errorCodes: [ParserErrorCode.EXTRANEOUS_MODIFIER],
+      diagnosticCodes: [ParserErrorCode.EXTRANEOUS_MODIFIER],
     );
     expect(parameter, isNotNull);
     expect(parameter, isFieldFormalParameter);
@@ -1079,7 +1079,7 @@ class C {
   void test_parseNormalFormalParameter_field_const_type() {
     NormalFormalParameter parameter = parseNormalFormalParameter(
       'const A this.a',
-      errorCodes: [ParserErrorCode.EXTRANEOUS_MODIFIER],
+      diagnosticCodes: [ParserErrorCode.EXTRANEOUS_MODIFIER],
     );
     expect(parameter, isNotNull);
     expect(parameter, isFieldFormalParameter);
@@ -1347,7 +1347,7 @@ class C {
   void test_parseNormalFormalParameter_simple_const_noType() {
     NormalFormalParameter parameter = parseNormalFormalParameter(
       'const a',
-      errorCodes: [ParserErrorCode.EXTRANEOUS_MODIFIER],
+      diagnosticCodes: [ParserErrorCode.EXTRANEOUS_MODIFIER],
     );
     expect(parameter, isNotNull);
     expect(parameter, isSimpleFormalParameter);
@@ -1360,7 +1360,7 @@ class C {
   void test_parseNormalFormalParameter_simple_const_type() {
     NormalFormalParameter parameter = parseNormalFormalParameter(
       'const A a',
-      errorCodes: [ParserErrorCode.EXTRANEOUS_MODIFIER],
+      diagnosticCodes: [ParserErrorCode.EXTRANEOUS_MODIFIER],
     );
     expect(parameter, isNotNull);
     expect(parameter, isSimpleFormalParameter);

pkg/analyzer/test/generated/nnbd_parser_test.dart

@@ -26,7 +26,7 @@ class NNBDParserTest extends FastaParserTestCase {
   @override
   CompilationUnitImpl parseCompilationUnit(
     String content, {
-    List<ErrorCode>? codes,
+    List<DiagnosticCode>? codes,
     List<ExpectedError>? errors,
     FeatureSet? featureSet,
   }) => super.parseCompilationUnit(