Skip to content

Commit 2550dad

Browse files
bkonyiCommit Queue
authored andcommitted
[ dart:io ] Breaking change: mark IOOverrides as abstract base
Fixes #56468 CoreLibraryReviewExempt: Only impacts dart:io Change-Id: I529ac7bbb50640cb1a0fba967cf0bcc6e3bb52aa Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/389520 Reviewed-by: Siva Annamalai <[email protected]> Reviewed-by: Jessy Yameogo <[email protected]> Commit-Queue: Ben Konyi <[email protected]> Auto-Submit: Ben Konyi <[email protected]>
1 parent 1597303 commit 2550dad

File tree

3 files changed

+13
-4
lines changed

3 files changed

+13
-4
lines changed

CHANGELOG.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,14 @@
2020
Dart SDK for ia32 anymore (support to execute the `dartvm` for ia32
2121
architecture is retained)
2222

23+
### Libraries
24+
25+
#### `dart:io`
26+
27+
- **Breaking Change** [#56468][]: Marked `IOOverrides` as an `abstract base`
28+
class.
29+
30+
[#56468]: https://github.com/dart-lang/sdk/issues/56468
2331

2432
## 3.9.0
2533

@@ -890,6 +898,7 @@ The AOT snapshot can be used as follows to run DDC:
890898
[pub#4445]: https://github.com/dart-lang/pub/issues/4445
891899
[#57084]: https://github.com/dart-lang/sdk/issues/57084
892900
[#56552]: https://github.com/dart-lang/sdk/issues/56552
901+
>>>>>>> BASE (d73f7bdb4366b447eb9874fe80381b8efd03c718 Generate `GeneralizingAstVisitor`, `TimedAstVisitor`, `Analy)
893902

894903
## 3.6.0
895904

sdk/lib/io/overrides.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ final _ioOverridesToken = Object();
2929
/// }, createDirectory: (String path) => new MyDirectory(path));
3030
/// }
3131
/// ```
32-
abstract class IOOverrides {
32+
abstract base class IOOverrides {
3333
static IOOverrides? _global;
3434

3535
static IOOverrides? get current {
@@ -379,7 +379,7 @@ abstract class IOOverrides {
379379
}
380380
}
381381

382-
class _IOOverridesScope extends IOOverrides {
382+
final class _IOOverridesScope extends IOOverrides {
383383
final IOOverrides? _previous;
384384

385385
// Directory

tests/standalone/io/io_override_test.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@ Future<Null> ioOverridesRunTest() async {
305305
await f;
306306
}
307307

308-
class MyIOOverrides extends IOOverrides {
308+
final class MyIOOverrides extends IOOverrides {
309309
Directory createDirectory(String path) => DirectoryMock.createDirectory(path);
310310
}
311311

@@ -331,7 +331,7 @@ globalIOOverridesZoneTest() {
331331
Expect.isTrue(dir is Directory);
332332
}
333333

334-
class EmptyOverride extends IOOverrides {}
334+
final class EmptyOverride extends IOOverrides {}
335335

336336
void emptyIOOverride() {
337337
IOOverrides.runWithIOOverrides(

0 commit comments

Comments
 (0)