Skip to content

Commit 4e4fec1

Browse files
srawlinsCommit Queue
authored andcommitted
DAS: Correct some broken comment references
Change-Id: I55df606eca2e08469ee7c0b8895fab5c7e5afb05 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401301 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Samuel Rawlins <[email protected]>
1 parent 69fef4b commit 4e4fec1

File tree

4 files changed

+11
-11
lines changed

4 files changed

+11
-11
lines changed

pkg/analysis_server/benchmark/integration/operation.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ abstract class Operation {
1515
Future<void>? perform(Driver driver);
1616
}
1717

18-
/// A [RequestOperation] sends a [JSON] request to the server.
18+
/// A [RequestOperation] sends a JSON request to the server.
1919
class RequestOperation extends Operation {
2020
final CommonInputConverter converter;
2121
final Map<String, dynamic> json;
@@ -62,7 +62,7 @@ class RequestOperation extends Operation {
6262
}
6363
}
6464

65-
/// A [ResponseOperation] waits for a [JSON] response from the server.
65+
/// A [ResponseOperation] waits for a JSON response from the server.
6666
class ResponseOperation extends Operation {
6767
static final Duration responseTimeout = Duration(seconds: 60);
6868
final CommonInputConverter converter;

pkg/analysis_server/lib/plugin/protocol/protocol_dart.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,9 @@ Element convertElement2(engine.Element2 element) {
7171
/// Return a protocol [ElementKind] corresponding to the given
7272
/// [engine.ElementKind].
7373
///
74-
/// This does not take into account that an instance of [ClassElement] can be an
75-
/// enum and an instance of [FieldElement] can be an enum constant.
76-
/// Use [convertElementToElementKind] where possible.
74+
/// This does not take into account that an instance of [engine.ClassElement]
75+
/// can be an enum and an instance of [engine.FieldElement] can be an enum
76+
/// constant. Use [convertElementToElementKind] where possible.
7777
ElementKind convertElementKind(engine.ElementKind kind) {
7878
if (kind == engine.ElementKind.CLASS) {
7979
return ElementKind.CLASS;

pkg/analysis_server/tool/spec/codegen_protocol_constants.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ String generateConstName(String domainName, String kind, String name) {
3838
String _fromComponents(List<String> components) =>
3939
components.map((String component) => component.toUpperCase()).join('_');
4040

41-
/// Return the components of the given [string] that are indicated by an upper
41+
/// Returns the components of the given String that are indicated by an upper
4242
/// case letter.
4343
Iterable<String> _split(String first) {
4444
var regExp = RegExp('[A-Z]');

pkg/analysis_server/tool/spec/from_html.dart

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ class ApiReader {
196196
/// Note that the event name should not include the domain name.
197197
///
198198
/// <params> has the same form as <object>, as described in
199-
/// [typeDeclFromHtml].
199+
/// [typeObjectFromHtml].
200200
///
201201
/// Child elements can occur in any order.
202202
Notification notificationFromHtml(dom.Element html, String context) {
@@ -376,7 +376,7 @@ class ApiReader {
376376
/// </refactoring>
377377
///
378378
/// <feedback> and <options> have the same form as <object>, as described in
379-
/// [typeDeclFromHtml].
379+
/// [typeObjectFromHtml].
380380
///
381381
/// Child elements can occur in any order.
382382
Refactoring refactoringFromHtml(dom.Element html) {
@@ -429,7 +429,7 @@ class ApiReader {
429429
/// Note that the method name should not include the domain name.
430430
///
431431
/// <params> and <result> have the same form as <object>, as described in
432-
/// [typeDeclFromHtml].
432+
/// [typeObjectFromHtml].
433433
///
434434
/// Child elements can occur in any order.
435435
Request requestFromHtml(dom.Element html, String context) {
@@ -481,7 +481,7 @@ class ApiReader {
481481
/// TYPE
482482
/// </type>
483483
///
484-
/// Where TYPE is any HTML that can be parsed by [typeDeclFromHtml].
484+
/// Where TYPE is any HTML that can be parsed by [typeObjectFromHtml].
485485
///
486486
/// Child elements can occur in any order.
487487
TypeDefinition typeDefinitionFromHtml(dom.Element html) {
@@ -555,7 +555,7 @@ class ApiReader {
555555
/// TYPE
556556
/// </field>
557557
///
558-
/// Where TYPE is any HTML that can be parsed by [typeDeclFromHtml].
558+
/// Where TYPE is any HTML that can be parsed by [typeObjectFromHtml].
559559
///
560560
/// In addition, the attribute optional="true" may be used to specify that the
561561
/// field is optional, and the attribute value="..." may be used to specify

0 commit comments

Comments
 (0)