Revert "[SDK] Second step in removing references to dart_precompiled_runtime"

This reverts commit 8576547.

Reason for revert: breaks dart2wasm golem benchmarks

Original change's description:
> [SDK] Second step in removing references to dart_precompiled_runtime
>
> TEST=ci
>
> Change-Id: I7b625de2090aa31fd649f0f67055c032f5878772
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/395065
> Reviewed-by: Alexander Aprelev <[email protected]>
> Commit-Queue: Siva Annamalai <[email protected]>

Change-Id: I524191ca9e26bb1d298eb56543bc0f419bfab4d3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/395462
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Brian Quinlan <[email protected]>
Commit-Queue: Siva Annamalai <[email protected]>

Author: a-siva

pkg/dart2wasm/tool/compile_benchmark

@@ -35,7 +35,7 @@ BIN_DIR="$OUT_DIR/$DART_CONFIGURATION"
 
 BINARYEN="$BIN_DIR/wasm-opt"
 DART="$BIN_DIR/dart"
-DART_AOT_RUNTIME="$BIN_DIR/dartaotruntime"
+DART_AOT_RUNTIME="$BIN_DIR/dart_precompiled_runtime"
 LIBRARIES_JSON_ARG="--libraries-spec=$SDK_DIR/sdk/lib/libraries.json"
 
 function find_flags {

pkg/vm/tool/dart_precompiled_runtime2

@@ -33,4 +33,4 @@ fi
 export DART_CONFIGURATION=${DART_CONFIGURATION:-ReleaseX64}
 BIN_DIR="$OUT_DIR$DART_CONFIGURATION"
 
-exec "$BIN_DIR"/dartaotruntime "$@"
+exec "$BIN_DIR"/dart_precompiled_runtime "$@"

tools/bots/test_matrix.json

@@ -73,6 +73,7 @@
     "dart2wasm_hostasserts": [
       ".dart_tool/package_config.json",
       "out/ReleaseX64/dart",
+      "out/ReleaseX64/dart_precompiled_runtime",
       "out/ReleaseX64/dartaotruntime",
       "out/ReleaseX64/dart2js_platform.dill",
       "out/ReleaseX64/dart2wasm.snapshot",
@@ -2770,7 +2771,7 @@
             "runtime",
             "dart2wasm",
             "create_sdk",
-            "dartaotruntime"
+            "dart_precompiled_runtime"
           ]
         },
         {
@@ -2805,7 +2806,7 @@
             "runtime",
             "dart2wasm",
             "create_sdk",
-            "dartaotruntime"
+            "dart_precompiled_runtime"
           ]
         },
         {
@@ -2838,7 +2839,7 @@
             "runtime",
             "dart2wasm",
             "create_sdk",
-            "dartaotruntime"
+            "dart_precompiled_runtime"
           ]
         },
         {
@@ -2871,7 +2872,7 @@
             "runtime",
             "dart2wasm",
             "create_sdk",
-            "dartaotruntime"
+            "dart_precompiled_runtime"
           ]
         },
         {
@@ -3371,6 +3372,7 @@
             "runtime",
             "gen_snapshot",
             "dartaotruntime",
+            "dart_precompiled_runtime",
             "dart2js_platform.dill",
             "dart2js_platform_unsound.dill",
             "kernel-service.dart.snapshot",

tools/bots/try_benchmarks.sh

@@ -181,7 +181,7 @@ EOF
     rm -rf tmp
   elif [ "$command" = linux-x64-build ]; then
     # NOTE: These are duplicated in tools/bots/test_matrix.json, keep in sync.
-    ./tools/build.py --mode=release --arch=x64 create_sdk runtime gen_snapshot dartaotruntime dart2js_platform.dill dart2js_platform_unsound.dill kernel-service.dart.snapshot ddc_stable_test ddc_canary_test dart2wasm_benchmark
+    ./tools/build.py --mode=release --arch=x64 create_sdk runtime gen_snapshot dartaotruntime dart_precompiled_runtime dart2js_platform.dill dart2js_platform_unsound.dill kernel-service.dart.snapshot ddc_stable_test ddc_canary_test dart2wasm_benchmark
   elif [ "$command" = linux-x64-archive ]; then
     export GZIP=-1
     strip -w \
@@ -260,6 +260,25 @@ EOF
       -K '_ZN4dart7Version4str_E' \
       -K '_ZN4dart7Version7commit_E' \
       -K '_ZN4dart9Bootstrap*_paths_E' out/ReleaseX64/dartaotruntime
+    strip -w \
+      -K 'kDartVmSnapshotData' \
+      -K 'kDartVmSnapshotInstructions' \
+      -K 'kDartCoreIsolateSnapshotData' \
+      -K 'kDartCoreIsolateSnapshotInstructions' \
+      -K '_ZN4dart3bin26observatory_assets_archiveE' \
+      -K '_ZN4dart3bin30observatory_assets_archive_lenE' \
+      -K '_ZN4dart3bin7Builtin22_builtin_source_paths_E' \
+      -K '_ZN4dart3bin7Builtin*_paths_E' \
+      -K '_ZN4dart3binL17vm_snapshot_data_E' \
+      -K '_ZN4dart3binL24isolate_snapshot_buffer_E' \
+      -K '_ZN4dart3binL27core_isolate_snapshot_data_E' \
+      -K '_ZN4dart3binL27observatory_assets_archive_E' \
+      -K '_ZN4dart3binL27vm_isolate_snapshot_buffer_E' \
+      -K '_ZN4dart3binL29core_isolate_snapshot_buffer_E' \
+      -K '_ZN4dart7Version14snapshot_hash_E' \
+      -K '_ZN4dart7Version4str_E' \
+      -K '_ZN4dart7Version7commit_E' \
+      -K '_ZN4dart9Bootstrap*_paths_E' out/ReleaseX64/dart_precompiled_runtime
     tar -czf linux-x64.tar.gz \
       --exclude .git \
       --exclude .gitignore \
@@ -282,6 +301,7 @@ EOF
       third_party/d8/linux/x64 \
       third_party/firefox_jsshell/ \
       out/ReleaseX64/dartaotruntime \
+      out/ReleaseX64/dart_precompiled_runtime \
       out/ReleaseX64/gen/utils/ddc \
       out/ReleaseX64/ddc_outline_unsound.dill \
       out/ReleaseX64/ddc_outline.dill \