Skip to content

Commit 6516829

Browse files
alexmarkovCommit Queue
authored andcommitted
[vm] Hide global symbols declared in assembly on mac/iOS
Declare those symbols with .private_extern in order to avoid exporting them from a shared library. (Flutter verifies exported symbols on iOS in release mode.) TEST=ci Change-Id: Iefc65e9616ed04801737c6e0dad3997581e1a173 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/447606 Reviewed-by: Ryan Macnak <[email protected]> Commit-Queue: Alexander Markov <[email protected]>
1 parent 847c92e commit 6516829

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

runtime/vm/ffi_trampolines_arm64.S

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414

1515
#if defined(__APPLE__)
1616
.globl _FfiCallTrampoline
17+
.private_extern _FfiCallTrampoline
1718
_FfiCallTrampoline:
1819
#else
1920
.globl FfiCallTrampoline
@@ -72,6 +73,7 @@ FfiCallTrampoline:
7273

7374
#if defined(__APPLE__)
7475
.globl _SimulatorFfiCalloutTrampoline
76+
.private_extern _SimulatorFfiCalloutTrampoline
7577
_SimulatorFfiCalloutTrampoline:
7678
#else
7779
.globl SimulatorFfiCalloutTrampoline
@@ -128,6 +130,7 @@ SimulatorFfiCalloutTrampoline:
128130

129131
#if defined(__APPLE__)
130132
.globl _SimulatorFfiCallbackTrampoline
133+
.private_extern _SimulatorFfiCallbackTrampoline
131134
_SimulatorFfiCallbackTrampoline:
132135
#else
133136
.globl SimulatorFfiCallbackTrampoline
@@ -181,6 +184,7 @@ SimulatorFfiCallbackTrampoline:
181184

182185
#if defined(__APPLE__)
183186
.globl _SimulatorFfiCallbackTrampolineEnd
187+
.private_extern _SimulatorFfiCallbackTrampolineEnd
184188
_SimulatorFfiCallbackTrampolineEnd:
185189
#else
186190
.globl SimulatorFfiCallbackTrampolineEnd

0 commit comments

Comments
 (0)