Fine. Send analysis_statistics events to analytics.

Change-Id: Idd2350803bf20b2cc59cfe98a8053d235d1ae108
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/453104
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

DEPS

@@ -147,7 +147,7 @@ vars = {
   "sync_http_rev": "6666fff944221891182e1f80bf56569338164d72",
   "tar_rev": "13479f7c2a18f499e840ad470cfcca8c579f6909",
   "test_rev": "a16f14975c5625ef99abc71f7e91bca5d8e55054",
-  "tools_rev": "19f91a030f5cef908820efade7e7638aea0248ac",
+  "tools_rev": "ce9d2ad5d246329af04cf03e1203ee665886741b",
   "vector_math_rev": "a7b7e9ccb931348dbfa669e0f8fea1bf97705b16",
   "web_rev": "816abcc1bf186f61c7e66e7f4c56d1554a61ab27",
   "webdev_rev": "0b2a408f6f64a29cd0d18ac7d2d407a4e1db8e0f",

pkg/analysis_server/lib/src/analysis_server.dart

@@ -823,6 +823,7 @@ abstract class AnalysisServer {
       _isFirstAnalysisSinceContextsBuilt = false;
       _dartFixPrompt.triggerCheck();
     }
+    analyticsManager.analysisStatusChanged(status.isWorking);
   }
 
   /// Immediately handles an LSP message by delegating to the

pkg/analysis_server/lib/src/analytics/analytics_manager.dart

@@ -10,6 +10,7 @@ import 'package:analysis_server/protocol/protocol_constants.dart';
 import 'package:analysis_server/src/analytics/active_request_data.dart';
 import 'package:analysis_server/src/analytics/context_structure.dart';
 import 'package:analysis_server/src/analytics/notification_data.dart';
+import 'package:analysis_server/src/analytics/percentile_calculator.dart';
 import 'package:analysis_server/src/analytics/plugin_data.dart';
 import 'package:analysis_server/src/analytics/request_data.dart';
 import 'package:analysis_server/src/analytics/session_data.dart';
@@ -83,6 +84,13 @@ class AnalyticsManager {
   /// represented by the key.
   final Map<String, Map<String, int>> _severityAdjustments = {};
 
+  /// The start time of the current window during which analysis was working,
+  /// or `null` if analysis is currently idle.
+  DateTime? _analysisWorkingStart;
+
+  /// Accumulates durations (in ms) of periods where analysis was working.
+  final PercentileCalculator _analysisWorkingDurations = PercentileCalculator();
+
   /// A periodic timer used to send analytics data. This timer should be
   /// cancelled at shutdown.
   Timer? periodicTimer;
@@ -128,6 +136,15 @@ class AnalyticsManager {
     );
   }
 
+  /// Called when analysis status changes to record period durations.
+  void analysisStatusChanged(bool isWorking) {
+    if (isWorking) {
+      _analysisWorkingStart ??= DateTime.now();
+    } else {
+      _finalizeOpenWorkingPeriod();
+    }
+  }
+
   /// Record that the set of plugins known to the [pluginManager] has changed.
   void changedPlugins(PluginManager pluginManager) {
     _pluginData.recordPlugins(pluginManager);
@@ -431,6 +448,13 @@ class AnalyticsManager {
       buffer.writeln('</ul>');
     }
 
+    if (_analysisWorkingDurations.valueCount > 0) {
+      h3('Analysis status periods');
+      buffer.writeln('<ul>');
+      li('workingDurations: ${_analysisWorkingDurations.toAnalyticsString()}');
+      buffer.writeln('</ul>');
+    }
+
     if (_lintUsageCounts.isNotEmpty) {
       h3('Lint usage counts');
       buffer.writeln('<ul>');
@@ -478,6 +502,16 @@ class AnalyticsManager {
     return buffer.toString();
   }
 
+  void _finalizeOpenWorkingPeriod() {
+    if (_analysisWorkingStart case var workingStart?) {
+      var durationMilliseconds =
+          DateTime.now().millisecondsSinceEpoch -
+          workingStart.millisecondsSinceEpoch;
+      _analysisWorkingDurations.addValue(durationMilliseconds);
+      _analysisWorkingStart = null;
+    }
+  }
+
   /// Record that the request with the given [id] was responded to at the given
   /// [sendTime].
   void _recordResponseData(String id, DateTime sendTime) {
@@ -525,6 +559,19 @@ class AnalyticsManager {
     }
   }
 
+  /// Send information about analysis statistics.
+  Future<void> _sendAnalysisStatistics() async {
+    if (_analysisWorkingDurations.valueCount == 0) {
+      return;
+    }
+    analytics.send(
+      Event.analysisStatistics(
+        workingDuration: _analysisWorkingDurations.toAnalyticsString(),
+      ),
+    );
+    _analysisWorkingDurations.clear();
+  }
+
   /// Send information about the number of times each lint is enabled in an
   /// analysis options file.
   Future<void> _sendLintUsageCounts() async {
@@ -564,6 +611,7 @@ class AnalyticsManager {
     await _sendNotificationHandlingTimes();
     await _sendLintUsageCounts();
     await _sendSeverityAdjustments();
+    await _sendAnalysisStatistics();
   }
 
   /// Send information about the response times of plugins.

pkg/analysis_server/test/src/analytics/analytics_manager_test.dart

@@ -150,6 +150,23 @@ class AnalyticsManagerTest with ResourceProviderMixin {
     ]);
   }
 
+  Future<void> test_server_notification_analysisStatistics() async {
+    _defaultStartup();
+
+    // Record a brief working period.
+    manager.analysisStatusChanged(true);
+    await Future<void>.delayed(const Duration(milliseconds: 2));
+    manager.analysisStatusChanged(false);
+
+    await manager.shutdown();
+    analytics.assertEvents([
+      _ExpectedEvent.session(),
+      _ExpectedEvent.analysisStatistics(
+        eventData: {'workingDuration': _IsPercentiles()},
+      ),
+    ]);
+  }
+
   Future<void> test_server_request_analysisDidChangeWorkspaceFolders() async {
     _defaultStartup();
     var params = DidChangeWorkspaceFoldersParams(
@@ -516,6 +533,9 @@ class _ExpectedEvent {
 
   _ExpectedEvent(this.eventName, this.eventData);
 
+  _ExpectedEvent.analysisStatistics({Map<String, Object?>? eventData})
+    : this(DashEvent.analysisStatistics, eventData);
+
   _ExpectedEvent.commandExecuted({Map<String, Object?>? eventData})
     : this(DashEvent.commandExecuted, eventData);