DAS: Generated protocol 'enums' can be real enums

File sizes are reduced:

```
analysis_server_client's protocol_common.dart    - 132k -> 102k (-23%)
analysis_server_client's protocol_generated.dart - 453k -> 433k (- 4%)
analysis_server's        protocol_generated.dart - 528k -> 509k (- 3%)
analyzer_plugin's        protocol_common.dart    - 139k -> 108k (-22%)
```

Change-Id: I8018f1d09e053c9d3df340ba31cdb07cbd29acf7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392842
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>

Author: srawlins

pkg/analysis_server/lib/protocol/protocol_generated.dart

@@ -50,7 +50,7 @@ class PerformRefactorCommandHandler extends AbstractRefactorCommandHandler {
 
     return result.mapResult((result) async {
       var refactoring = await getRefactoring(
-        RefactoringKind(kind),
+        RefactoringKind.values.byName(kind),
         result,
         offset,
         length,

pkg/analysis_server/lib/src/lsp/handlers/commands/perform_refactor.dart

@@ -49,7 +49,7 @@ class ValidateRefactorCommandHandler extends AbstractRefactorCommandHandler {
     var result = await requireResolvedUnit(path);
     return result.mapResult((result) async {
       var refactoring = await getRefactoring(
-        RefactoringKind(kind),
+        RefactoringKind.values.byName(kind),
         result,
         offset,
         length,

pkg/analysis_server/lib/src/lsp/handlers/commands/validate_refactor.dart

@@ -1238,14 +1238,14 @@ class LspAnalysisServer extends AnalysisServer {
       // LSP we're supposed to have them available per request. Assume that
       // we'll only receive requests for files that are currently open.
       var pluginSubscriptions = plugin.AnalysisSetSubscriptionsParams({
-        for (var service in plugin.AnalysisService.VALUES)
+        for (var service in plugin.AnalysisService.values)
           service: priorityFilesList,
       });
       pluginManager.setAnalysisSetSubscriptionsParams(pluginSubscriptions);
     }
 
     notificationManager.setSubscriptions({
-      for (var service in protocol.AnalysisService.VALUES)
+      for (var service in protocol.AnalysisService.values)
         service: priorityFiles,
     });
   }

pkg/analysis_server/lib/src/lsp/lsp_analysis_server.dart

@@ -785,11 +785,6 @@ lsp.DiagnosticSeverity pluginToDiagnosticSeverity(
     plugin.AnalysisErrorSeverity.ERROR => lsp.DiagnosticSeverity.Error,
     plugin.AnalysisErrorSeverity.WARNING => lsp.DiagnosticSeverity.Warning,
     plugin.AnalysisErrorSeverity.INFO => lsp.DiagnosticSeverity.Information,
-    // Note: LSP also supports "Hint", but they won't render in things like the
-    // VS Code errors list as they're apparently intended to communicate
-    // non-visible diagnostics back (for example, if you wanted to grey out
-    // unreachable code without producing an item in the error list).
-    _ => throw 'Unknown AnalysisErrorSeverity: $severity',
   };
 }
 

pkg/analysis_server/lib/src/lsp/mapping.dart

@@ -250,22 +250,17 @@ abstract class AbstractNotificationManager {
   void setSubscriptions(
     Map<server.AnalysisService, Set<String>> newSubscriptions,
   ) {
-    /// Return the collector associated with the given service, or `null` if the
-    /// service is not handled by this manager.
+    /// Returns the collector associated with the given service, or `null` if
+    /// the service is not handled by this manager.
     ResultCollector<Object?>? collectorFor(server.AnalysisService service) {
-      switch (service) {
-        case server.AnalysisService.FOLDING:
-          return folding;
-        case server.AnalysisService.HIGHLIGHTS:
-          return highlights;
-        case server.AnalysisService.NAVIGATION:
-          return navigation;
-        case server.AnalysisService.OCCURRENCES:
-          return occurrences;
-        case server.AnalysisService.OUTLINE:
-          return outlines;
-      }
-      return null;
+      return switch (service) {
+        server.AnalysisService.FOLDING => folding,
+        server.AnalysisService.HIGHLIGHTS => highlights,
+        server.AnalysisService.NAVIGATION => navigation,
+        server.AnalysisService.OCCURRENCES => occurrences,
+        server.AnalysisService.OUTLINE => outlines,
+        _ => null,
+      };
     }
 
     Set<server.AnalysisService> services = HashSet<server.AnalysisService>();

pkg/analysis_server/lib/src/plugin/notification_manager.dart

@@ -11,7 +11,7 @@ class RequestConverter {
   plugin.AnalysisService convertAnalysisService(
     server.AnalysisService service,
   ) {
-    return plugin.AnalysisService(service.name);
+    return plugin.AnalysisService.values.byName(service.name);
   }
 
   plugin.AnalysisSetPriorityFilesParams convertAnalysisSetPriorityFilesParams(

pkg/analysis_server/lib/src/plugin/request_converter.dart

@@ -219,8 +219,8 @@ AnalysisError newAnalysisError_fromEngine(
   errorSeverity ??= errorCode.errorSeverity;
 
   // done
-  var severity = AnalysisErrorSeverity(errorSeverity.name);
-  var type = AnalysisErrorType(errorCode.type.name);
+  var severity = AnalysisErrorSeverity.values.byName(errorSeverity.name);
+  var type = AnalysisErrorType.values.byName(errorCode.type.name);
   var message = error.message;
   var code = errorCode.name.toLowerCase();
   List<DiagnosticMessage>? contextMessages;

pkg/analysis_server/lib/src/protocol_server.dart

@@ -1800,7 +1800,7 @@ class SubscriptionsPage extends DiagnosticPageWithNav {
   Future<void> generateContent(Map<String, String> params) async {
     // server domain
     h3('Server domain subscriptions');
-    ul(ServerService.VALUES, (item) {
+    ul(ServerService.values, (item) {
       if (server.serverServices.contains(item)) {
         buf.write('$item (has subscriptions)');
       } else {
@@ -1810,7 +1810,7 @@ class SubscriptionsPage extends DiagnosticPageWithNav {
 
     // analysis domain
     h3('Analysis domain subscriptions');
-    for (var service in AnalysisService.VALUES) {
+    for (var service in AnalysisService.values) {
       buf.writeln('${service.name}<br>');
       ul(server.analysisServices[service] ?? {}, (item) {
         buf.write('$item');

pkg/analysis_server/lib/src/status/diagnostics.dart

@@ -2693,7 +2693,7 @@ class HighlightTypeTest {
   void test_constructor() {
     expect(
       HighlightRegionType.CLASS,
-      HighlightRegionType(HighlightRegionType.CLASS.name),
+      HighlightRegionType.values.byName(HighlightRegionType.CLASS.name),
     );
   }
 
@@ -2703,7 +2703,7 @@ class HighlightTypeTest {
 
   void test_valueOf_unknown() {
     expect(() {
-      HighlightRegionType('no-such-type');
-    }, throwsException);
+      HighlightRegionType.values.byName('no-such-type');
+    }, throwsArgumentError);
   }
 }