analyzer: elementUsageFrontierDetectors: Consider super constructor parameters corresponding to super-parameters

The primary effect this has is to report super-parameters whose
corresponding super-constructor parameters are `@deprecated`. Also
`@experimental`.

Let's say we have a deprecated constructor parameter, and code which
calls that constructor as a super-constructor (implicitly or
explicitly). If the code has no deprecation warnings, it should be
safe to remove the deprecated constructor. This is not the case
without this additional safeguard.

Change-Id: Iacec920d680dfb5d6ccbe19d3f3f54e24a240a9f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/453441
Commit-Queue: Samuel Rawlins <[email protected]>
Reviewed-by: Paul Berry <[email protected]>

Author: srawlins

pkg/analyzer/lib/src/error/best_practices_verifier.dart

@@ -317,9 +317,6 @@ class BestPracticesVerifier extends RecursiveAstVisitor<void> {
       v.pushElement(element);
     }
 
-    // TODO(srawlins): Use _elementUsageFrontierDetectors to detect
-    // super-parameters corresponding to `@Deprecated` or `@experimental`
-    // parameters.
     // TODO(srawlins): Use _elementUsageFrontierDetectors to detect
     // `@Deprecated` or `@experimental` parameters in a redirecting factory
     // constructor.
@@ -880,6 +877,9 @@ class BestPracticesVerifier extends RecursiveAstVisitor<void> {
 
   @override
   void visitSuperFormalParameter(SuperFormalParameter node) {
+    for (var v in _elementUsageFrontierDetectors) {
+      v.superFormalParameter(node);
+    }
     _checkFinalParameter(node, node.keyword);
     super.visitSuperFormalParameter(node);
   }

pkg/analyzer/lib/src/error/element_usage_detector.dart

@@ -223,6 +223,10 @@ class ElementUsageDetector<TagInfo extends Object> {
     _invocationArguments(node.element, node.argumentList);
   }
 
+  void superFormalParameter(SuperFormalParameter node) {
+    checkUsage(node.declaredFragment!.element.superConstructorParameter, node);
+  }
+
   void _invocationArguments(Element? element, ArgumentList arguments) {
     element = element?.baseElement;
     if (element is ExecutableElement) {

pkg/analyzer/test/src/diagnostics/deprecated_member_use_test.dart

@@ -1654,6 +1654,117 @@ void f(A a) {
     );
   }
 
+  test_parameterInSuper_explicitInvocation() async {
+    newFile('$workspaceRootPath/aaa/lib/a.dart', r'''
+class A {
+  A([@deprecated int? p]);
+}
+''');
+
+    await assertErrorsInCode(
+      r'''
+import 'package:aaa/a.dart';
+
+class B extends A {
+  B() : super(7);
+}
+''',
+      [error(HintCode.deprecatedMemberUse, 64, 1)],
+    );
+  }
+
+  test_parameterInSuper_explicitInvocation_namedParameter() async {
+    newFile('$workspaceRootPath/aaa/lib/a.dart', r'''
+class A {
+  A({@deprecated int? p});
+}
+''');
+
+    await assertErrorsInCode(
+      r'''
+import 'package:aaa/a.dart';
+
+class B extends A {
+  B() : super(p: 7);
+}
+''',
+      [error(HintCode.deprecatedMemberUse, 64, 1)],
+    );
+  }
+
+  test_parameterInSuper_implicitArgument() async {
+    newFile('$workspaceRootPath/aaa/lib/a.dart', r'''
+class A {
+  A([@deprecated int? p]);
+}
+''');
+
+    await assertErrorsInCode(
+      r'''
+import 'package:aaa/a.dart';
+
+class B extends A {
+  B([super.p]);
+}
+''',
+      [error(HintCode.deprecatedMemberUse, 55, 7)],
+    );
+  }
+
+  test_parameterInSuper_implicitArgument_alsoDeprecated() async {
+    newFile('$workspaceRootPath/aaa/lib/a.dart', r'''
+class A {
+  A([@deprecated int? p]);
+}
+''');
+
+    await assertNoErrorsInCode(r'''
+import 'package:aaa/a.dart';
+
+class B extends A {
+  B([@deprecated super.p]);
+}
+''');
+  }
+
+  test_parameterInSuper_implicitArgument_explicitInvocation() async {
+    newFile('$workspaceRootPath/aaa/lib/a.dart', r'''
+class A {
+  A.named([@deprecated int? p]);
+}
+''');
+
+    await assertErrorsInCode(
+      r'''
+import 'package:aaa/a.dart';
+
+class B extends A {
+  B([super.p]) : super.named();
+}
+''',
+      [error(HintCode.deprecatedMemberUse, 55, 7)],
+    );
+  }
+
+  test_parameterInSuper_implicitInvocation_namedParameter() async {
+    newFile('$workspaceRootPath/aaa/lib/a.dart', r'''
+class A {
+  A({@deprecated int? p});
+}
+''');
+
+    await assertErrorsInCode(
+      r'''
+import 'package:aaa/a.dart';
+
+class B extends A {
+  B({super.p});
+}
+''',
+      [error(HintCode.deprecatedMemberUse, 55, 7)],
+    );
+  }
+
   test_postfixExpression_deprecatedGetter() async {
     await assertErrorsInCode2(
       externalCode: r'''