Skip to content

Commit 7e18fad

Browse files
stereotype441Commit Queue
authored andcommitted
Remove expression info invalidation from nonNullAssert_end.
This logic was a hack that was needed for the null safety migration tool, to account for the fact that when inserting a non-null assertion operator (`!`), it used the same Expression object to refer to the non-null assertion operation as it did to refer to the operand. So the normal flow analysis mechanism for ignoring irrelevant expression info (noticing that the expressions are different) didn't work. Now that the null safety migration tool no longer exists, flow analysis no longer needs this hack. Change-Id: I63a504371a70e3eb0b43303010cb0b4eac032479 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/389262 Commit-Queue: Paul Berry <[email protected]> Reviewed-by: Kallen Tu <[email protected]>
1 parent 2bba463 commit 7e18fad

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

pkg/_fe_analyzer_shared/lib/src/flow_analysis/flow_analysis.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5042,8 +5042,6 @@ class _FlowAnalysisImpl<Node extends Object, Statement extends Node,
50425042
if (operandReference != null) {
50435043
_current = _current.tryMarkNonNullable(this, operandReference).ifTrue;
50445044
}
5045-
// Invalidate any expression info that was associated with [operand].
5046-
_getExpressionInfo(operand);
50475045
}
50485046

50495047
@override

0 commit comments

Comments
 (0)