Skip to content

Commit 9a31095

Browse files
aamCommit Queue
authored andcommitted
[build] Introduce 'arch' parameter for stress test script.
Fixes https://ci.chromium.org/ui/p/dart/builders/try/iso-stress-linux-arm64-try/4 Change-Id: Iba64548fb3396a3536e3669992d6c778ae9c90cb Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/424700 Reviewed-by: Siva Annamalai <[email protected]> Commit-Queue: Alexander Aprelev <[email protected]>
1 parent 65d5319 commit 9a31095

File tree

2 files changed

+75
-35
lines changed

2 files changed

+75
-35
lines changed

runtime/tests/concurrency/run_stress_test_shards.dart

Lines changed: 36 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -135,37 +135,7 @@ void writeUnexpectedCrashesFile(List<PotentialCrash> crashes) {
135135

136136
const int tsanShards = 200;
137137

138-
final configurations = <TestRunner>[
139-
JitTestRunner('out/DebugX64', [
140-
'--disable-dart-dev',
141-
'runtime/tests/concurrency/generated_stress_test.dart.jit.dill',
142-
]),
143-
JitTestRunner('out/ReleaseX64', [
144-
'--disable-dart-dev',
145-
'--no-inline-alloc',
146-
'--use-slow-path',
147-
'--deoptimize-on-runtime-call-every=3',
148-
'runtime/tests/concurrency/generated_stress_test.dart.jit.dill',
149-
]),
150-
for (int i = 0; i < tsanShards; ++i)
151-
JitTestRunner('out/ReleaseTSANX64', [
152-
'--disable-dart-dev',
153-
'-Drepeat=4',
154-
'-Dshard=$i',
155-
'-Dshards=$tsanShards',
156-
'runtime/tests/concurrency/generated_stress_test.dart.jit.dill',
157-
]),
158-
AotTestRunner(
159-
'out/ReleaseX64',
160-
['runtime/tests/concurrency/generated_stress_test.dart.aot.dill'],
161-
[],
162-
),
163-
AotTestRunner(
164-
'out/DebugX64',
165-
['runtime/tests/concurrency/generated_stress_test.dart.aot.dill'],
166-
[],
167-
),
168-
];
138+
late final List<TestRunner> configurations;
169139

170140
main(List<String> arguments) async {
171141
final parser = ArgParser()
@@ -175,13 +145,46 @@ main(List<String> arguments) async {
175145
help: 'unused parameter to make sharding infra work', defaultsTo: '')
176146
..addFlag('copy-coredumps',
177147
help: 'whether to copy binaries for coredumps', defaultsTo: false)
178-
..addOption("previous-results",
179-
help: "An earlier results.json for balancing tests across shards.");
148+
..addOption('previous-results',
149+
help: 'An earlier results.json for balancing tests across shards.')
150+
..addOption('arch', help:'architecture to be tested', defaultsTo: 'X64');
180151

181152
final options = parser.parse(arguments);
182153
final shards = int.parse(options['shards']);
183154
final shard = int.parse(options['shard']) - 1;
184155
final copyCoredumps = options['copy-coredumps'] as bool;
156+
final arch = options['arch'].toUpperCase();
157+
configurations = <TestRunner>[
158+
JitTestRunner('out/Debug$arch', [
159+
'--disable-dart-dev',
160+
'runtime/tests/concurrency/generated_stress_test.dart.jit.dill',
161+
]),
162+
JitTestRunner('out/Release$arch', [
163+
'--disable-dart-dev',
164+
'--no-inline-alloc',
165+
'--use-slow-path',
166+
'--deoptimize-on-runtime-call-every=3',
167+
'runtime/tests/concurrency/generated_stress_test.dart.jit.dill',
168+
]),
169+
for (int i = 0; i < tsanShards; ++i)
170+
JitTestRunner('out/ReleaseTSAN$arch', [
171+
'--disable-dart-dev',
172+
'-Drepeat=4',
173+
'-Dshard=$i',
174+
'-Dshards=$tsanShards',
175+
'runtime/tests/concurrency/generated_stress_test.dart.jit.dill',
176+
]),
177+
AotTestRunner(
178+
'out/Release$arch',
179+
['runtime/tests/concurrency/generated_stress_test.dart.aot.dill'],
180+
[],
181+
),
182+
AotTestRunner(
183+
'out/Debug$arch',
184+
['runtime/tests/concurrency/generated_stress_test.dart.aot.dill'],
185+
[],
186+
)];
187+
185188

186189
// Tasks will eventually be killed if they do not have any output for some
187190
// time. So we'll explicitly print something every 4 minutes.

tools/bots/test_matrix.json

Lines changed: 39 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3584,7 +3584,24 @@
35843584
},
35853585
"steps": [
35863586
{
3587-
"name": "Build Dart VM - JIT and AOT",
3587+
"name": "Build Dart VM - JIT and AOT - gen_snapshot",
3588+
"script": "tools/build.py",
3589+
"arguments": [
3590+
"--mode=debug,release",
3591+
"gen_snapshot"
3592+
]
3593+
},
3594+
{
3595+
"name": "Build Dart VM - JIT and AOT - runtime/bin:dart, run_vm_tests",
3596+
"script": "tools/build.py",
3597+
"arguments": [
3598+
"--mode=debug,release",
3599+
"runtime/bin:dart",
3600+
"runtime/bin:run_vm_tests"
3601+
]
3602+
},
3603+
{
3604+
"name": "Build Dart VM - JIT and AOT - runtime, dartaotruntime",
35883605
"script": "tools/build.py",
35893606
"arguments": [
35903607
"--mode=debug,release",
@@ -3593,7 +3610,26 @@
35933610
]
35943611
},
35953612
{
3596-
"name": "Build Dart VM - JIT and AOT (Release TSAN)",
3613+
"name": "Build Dart VM - JIT and AOT (Release TSAN) - gen_snapshot",
3614+
"script": "tools/build.py",
3615+
"arguments": [
3616+
"--mode=release",
3617+
"--sanitizer=tsan",
3618+
"gen_snapshot"
3619+
]
3620+
},
3621+
{
3622+
"name": "Build Dart VM - JIT and AOT (Release TSAN)- runtime/bin:dart, run_vm_tests",
3623+
"script": "tools/build.py",
3624+
"arguments": [
3625+
"--mode=release",
3626+
"--sanitizer=tsan",
3627+
"runtime/bin:dart",
3628+
"runtime/bin:run_vm_tests"
3629+
]
3630+
},
3631+
{
3632+
"name": "Build Dart VM - JIT and AOT (Release TSAN) - runtime, dartaotruntime",
35973633
"script": "tools/build.py",
35983634
"arguments": [
35993635
"--mode=release",
@@ -3641,6 +3677,7 @@
36413677
"arguments": [
36423678
"${build_root}/dart",
36433679
"runtime/tests/concurrency/run_stress_test_shards.dart",
3680+
"--arch=${arch}",
36443681
"--copy-coredumps"
36453682
],
36463683
"shards": 10,

0 commit comments

Comments
 (0)