[DAS] Fixes comment references completion outside braces

Fixes: Dart-Code/Dart-Code#5507
Change-Id: Icd83264a3d31118c4ee837e2dd2303fd1e10b42a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/427460
Auto-Submit: Felipe Morschel <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>

Author: FMorschel

pkg/analysis_server/lib/src/services/completion/dart/in_scope_completion_pass.dart

@@ -678,7 +678,9 @@ class InScopeCompletionPass extends SimpleAstVisitor<void> {
 
   @override
   void visitComment(Comment node) {
-    node.visitChildren(this);
+    // This should never call its children. They should, instead, be called
+    // directly by the containing node. Making sure all annotated nodes have
+    // the comments on the children call is the right way to handle this case.
   }
 
   @override

pkg/analysis_server/test/services/completion/dart/location/dart_doc_test.dart

@@ -306,6 +306,17 @@ suggestions
 ''');
   }
 
+  Future<void> test_notInSquareBraces() async {
+    allowedIdentifiers = const {'MyClass1'};
+    await computeSuggestions('''
+/// This doc should not suggest the commented class name [] outside the braces ^
+class MyClass1 {}
+''');
+    assertResponse(r'''
+suggestions
+''');
+  }
+
   Future<void> test_parameter() async {
     allowedIdentifiers = const {'param1'};
     await computeSuggestions('''