Skip to content

Commit cfb4fed

Browse files
srawlinsCommit Queue
authored andcommitted
linter: privatize LintRuleUnitContext.file
Work towards #50986 Also remove under-used libraryFragment getter. Change-Id: I6804bacc62abb483a339b28b8d5a226b689aa68d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/428224 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Samuel Rawlins <[email protected]>
1 parent c0e2f38 commit cfb4fed

File tree

1 file changed

+7
-10
lines changed

1 file changed

+7
-10
lines changed

pkg/analyzer/lib/src/lint/linter.dart

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -284,22 +284,23 @@ final class LinterContextWithResolvedResults implements LinterContext {
284284

285285
@override
286286
bool get isInLibDir => LinterContext._isInLibDir(
287-
definingUnit.libraryFragment.source.fullName,
287+
definingUnit.unit.declaredFragment?.source.fullName,
288288
package,
289289
);
290290

291291
@override
292292
bool get isInTestDirectory {
293293
if (package case var package?) {
294-
var file = definingUnit.file;
294+
var file = definingUnit._file;
295295
return package.isInTestDirectory(file);
296296
}
297297
return false;
298298
}
299299

300300
@experimental
301301
@override
302-
LibraryElement get libraryElement2 => definingUnit.libraryFragment.element;
302+
LibraryElement get libraryElement2 =>
303+
definingUnit.unit.declaredFragment!.element;
303304
}
304305

305306
/// Describes an [AbstractAnalysisRule] which reports exactly one type of
@@ -370,21 +371,17 @@ abstract class LintRule extends AbstractAnalysisRule {
370371
/// Provides access to information needed by lint rules that is not available
371372
/// from AST nodes or the element model.
372373
class LintRuleUnitContext {
373-
final File file;
374+
final File _file;
374375
final String content;
375376
final ErrorReporter errorReporter;
376377
final CompilationUnit unit;
377378

378379
LintRuleUnitContext({
379-
required this.file,
380+
required File file,
380381
required this.content,
381382
required this.errorReporter,
382383
required this.unit,
383-
});
384-
385-
/// The library fragment representing the compilation unit.
386-
@experimental
387-
LibraryFragment get libraryFragment => unit.declaredFragment!;
384+
}) : _file = file;
388385
}
389386

390387
/// Describes an [AbstractAnalysisRule] which reports diagnostics using multiple

0 commit comments

Comments
 (0)