Skip to content

Commit ad562fd

Browse files
jensjohaCommit Queue
authored andcommitted
[parser] Rename accidentally committed 'allowLazyFoo' parameter
In https://dart-review.googlesource.com/c/sdk/+/382162 I accidentally left in the debug-named version of a parameter. This renames it to not be called foo. Change-Id: Ib9421b4a5ee63b9b6296a09d14b4ab73ae414742 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/403586 Commit-Queue: Jens Johansen <[email protected]> Reviewed-by: Johnni Winther <[email protected]>
1 parent 9b631bf commit ad562fd

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

pkg/_fe_analyzer_shared/lib/src/scanner/string_scanner.dart

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -100,9 +100,7 @@ class StringScanner extends AbstractScanner {
100100
bool asciiOnly, int extraOffset, bool allowLazy) {
101101
return new StringTokenImpl.fromSubstring(
102102
type, _string, start, scanOffset + extraOffset, tokenStart,
103-
canonicalize: true,
104-
precedingComments: comments,
105-
allowLazyFoo: allowLazy);
103+
canonicalize: true, precedingComments: comments, allowLazy: allowLazy);
106104
}
107105

108106
@override

pkg/_fe_analyzer_shared/lib/src/scanner/token_impl.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,10 @@ class StringTokenImpl extends SimpleToken implements StringToken {
5454
TokenType type, String data, int start, int end, int charOffset,
5555
{bool canonicalize = false,
5656
CommentToken? precedingComments,
57-
bool allowLazyFoo = true})
57+
bool allowLazy = true})
5858
: super(type, charOffset, precedingComments) {
5959
int length = end - start;
60-
if (!allowLazyFoo || length <= LAZY_THRESHOLD) {
60+
if (!allowLazy || length <= LAZY_THRESHOLD) {
6161
valueOrLazySubstring = canonicalize
6262
? canonicalizeSubString(data, start, end)
6363
: data.substring(start, end);
@@ -73,10 +73,10 @@ class StringTokenImpl extends SimpleToken implements StringToken {
7373
*/
7474
StringTokenImpl.fromUtf8Bytes(TokenType type, Uint8List data, int start,
7575
int end, bool asciiOnly, int charOffset,
76-
{CommentToken? precedingComments, bool allowLazyFoo = true})
76+
{CommentToken? precedingComments, bool allowLazy = true})
7777
: super(type, charOffset, precedingComments) {
7878
int length = end - start;
79-
if (!allowLazyFoo || length <= LAZY_THRESHOLD) {
79+
if (!allowLazy || length <= LAZY_THRESHOLD) {
8080
valueOrLazySubstring =
8181
canonicalizeUtf8SubString(data, start, end, asciiOnly);
8282
} else {

pkg/_fe_analyzer_shared/lib/src/scanner/utf8_bytes_scanner.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ class Utf8BytesScanner extends AbstractScanner {
251251
bool asciiOnly, int extraOffset, bool allowLazy) {
252252
return new StringTokenImpl.fromUtf8Bytes(
253253
type, _bytes, start, byteOffset + extraOffset, asciiOnly, tokenStart,
254-
precedingComments: comments, allowLazyFoo: allowLazy);
254+
precedingComments: comments, allowLazy: allowLazy);
255255
}
256256

257257
@override

0 commit comments

Comments
 (0)