[vm] Move handle check after barrier in CompileFunction runtime entry.

Remove redundant AOT runtime guard against compilation.

TEST=tsan
Bug: #53718
Change-Id: I1f1b5b0f01cfa08c13b3d3b7695297fac02c9cce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/431300
Reviewed-by: Alexander Aprelev <[email protected]>
Commit-Queue: Ryan Macnak <[email protected]>

Author: rmacnak-google

runtime/vm/compiler/jit/compiler.cc

@@ -1215,20 +1215,20 @@ bool Compiler::CanOptimizeFunction(Thread* thread, const Function& function) {
 }
 
 ObjectPtr Compiler::CompileFunction(Thread* thread, const Function& function) {
-  FATAL("Attempt to compile function %s", function.ToCString());
+  FATAL("Attempt to compile function %s", function.ToFullyQualifiedCString());
   return Error::null();
 }
 
 ErrorPtr Compiler::EnsureUnoptimizedCode(Thread* thread,
                                          const Function& function) {
-  FATAL("Attempt to compile function %s", function.ToCString());
+  FATAL("Attempt to compile function %s", function.ToFullyQualifiedCString());
   return Error::null();
 }
 
 ObjectPtr Compiler::CompileOptimizedFunction(Thread* thread,
                                              const Function& function,
                                              intptr_t osr_id) {
-  FATAL("Attempt to compile function %s", function.ToCString());
+  FATAL("Attempt to compile function %s", function.ToFullyQualifiedCString());
   return Error::null();
 }
 

runtime/vm/runtime_entry.cc

@@ -3569,14 +3569,7 @@ DEFINE_RUNTIME_ENTRY(TraceICCall, 2) {
 //   Arg0: function object.
 DEFINE_RUNTIME_ENTRY(CompileFunction, 1) {
   ASSERT(thread->IsDartMutatorThread());
-  const Function& function = Function::CheckedHandle(zone, arguments.ArgAt(0));
 
-#if defined(DART_PRECOMPILED_RUNTIME)
-  FATAL("Precompilation missed function %s (%s, %s)\n",
-        function.ToLibNamePrefixedQualifiedCString(),
-        function.token_pos().ToCString(),
-        Function::KindToCString(function.kind()));
-#else
   {
     // Another isolate's mutator thread may have created [function] and
     // published it via an ICData, MegamorphicCache etc. Entering the lock below
@@ -3586,9 +3579,11 @@ DEFINE_RUNTIME_ENTRY(CompileFunction, 1) {
     SafepointReadRwLocker ml(thread, thread->isolate_group()->program_lock());
   }
 
+  // After the barrier, since this will read the object's header.
+  const Function& function = Function::CheckedHandle(zone, arguments.ArgAt(0));
+
   // Will throw if compilation failed (e.g. with compile-time error).
   function.EnsureHasCode();
-#endif
 }
 
 // This is called from function that needs to be optimized.