[kernel] Add *InternalNodeMixin visitor mixins

This adds mixins for visitors that implement handling of internal nodes. These nodes are replaced during constant evaluation and should there not be handle by backends.

TEST=existing

Change-Id: Iec76af357c11fd54e97a4db82c7aa52e31ba9dd3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/456680
Reviewed-by: Nicholas Shahan <[email protected]>
Reviewed-by: Chloe Stefantsova <[email protected]>
Reviewed-by: Alexander Markov <[email protected]>
Reviewed-by: Ömer Ağacan <[email protected]>
Commit-Queue: Johnni Winther <[email protected]>

Author: johnniwinther

pkg/dart2wasm/lib/target.dart

@@ -453,6 +453,9 @@ class WasmTarget extends Target {
   @override
   bool get supportsSetLiterals => true;
 
+  @override
+  bool get supportsFileUriExpression => true;
+
   @override
   int get enabledLateLowerings => LateLowering.all;
 

pkg/dev_compiler/lib/src/kernel/compiler.dart

@@ -78,7 +78,9 @@ abstract class Compiler {
 class ProgramCompiler extends ComputeOnceConstantVisitor<js_ast.Expression>
     with
         OnceConstantVisitorDefaultMixin<js_ast.Expression>,
+        StatementVisitorInternalNodeMixin<js_ast.Statement>,
         StatementVisitorExperimentExclusionMixin<js_ast.Statement>,
+        ExpressionVisitorInternalNodeMixin<js_ast.Expression>,
         ExpressionVisitorExperimentExclusionMixin<js_ast.Expression>
     implements
         StatementVisitor<js_ast.Statement>,
@@ -7685,36 +7687,6 @@ class ProgramCompiler extends ComputeOnceConstantVisitor<js_ast.Expression>
     return js_ast.Expression.binary(parts, '+');
   }
 
-  @override
-  js_ast.Expression visitListConcatenation(ListConcatenation node) {
-    // Only occurs inside unevaluated constants.
-    throw UnsupportedError('List concatenation');
-  }
-
-  @override
-  js_ast.Expression visitSetConcatenation(SetConcatenation node) {
-    // Only occurs inside unevaluated constants.
-    throw UnsupportedError('Set concatenation');
-  }
-
-  @override
-  js_ast.Expression visitMapConcatenation(MapConcatenation node) {
-    // Only occurs inside unevaluated constants.
-    throw UnsupportedError('Map concatenation');
-  }
-
-  @override
-  js_ast.Expression visitInstanceCreation(InstanceCreation node) {
-    // Only occurs inside unevaluated constants.
-    throw UnsupportedError('Instance creation');
-  }
-
-  @override
-  js_ast.Expression visitFileUriExpression(FileUriExpression node) {
-    // Only occurs inside unevaluated constants.
-    throw UnsupportedError('File URI expression');
-  }
-
   @override
   js_ast.Expression visitConstructorTearOff(ConstructorTearOff node) {
     throw UnsupportedError('Constructor tear off');
@@ -8547,43 +8519,6 @@ class ProgramCompiler extends ComputeOnceConstantVisitor<js_ast.Expression>
     return header;
   }
 
-  @override
-  js_ast.Statement visitIfCaseStatement(IfCaseStatement node) {
-    // This node is internal to the front end and removed by the constant
-    // evaluator.
-    throw UnsupportedError('ProgramCompiler.visitIfCaseStatement');
-  }
-
-  @override
-  js_ast.Expression visitPatternAssignment(PatternAssignment node) {
-    // This node is internal to the front end and removed by the constant
-    // evaluator.
-    throw UnsupportedError('ProgramCompiler.visitPatternAssignment');
-  }
-
-  @override
-  js_ast.Statement visitPatternSwitchStatement(PatternSwitchStatement node) {
-    // This node is internal to the front end and removed by the constant
-    // evaluator.
-    throw UnsupportedError('ProgramCompiler.visitPatternSwitchStatement');
-  }
-
-  @override
-  js_ast.Statement visitPatternVariableDeclaration(
-    PatternVariableDeclaration node,
-  ) {
-    // This node is internal to the front end and removed by the constant
-    // evaluator.
-    throw UnsupportedError('ProgramCompiler.visitPatternVariableDeclaration');
-  }
-
-  @override
-  js_ast.Expression visitSwitchExpression(SwitchExpression node) {
-    // This node is internal to the front end and removed by the constant
-    // evaluator.
-    throw UnsupportedError('ProgramCompiler.visitSwitchExpression');
-  }
-
   @override
   js_ast.Expression visitAuxiliaryExpression(AuxiliaryExpression node) {
     throw UnsupportedError(

pkg/dev_compiler/lib/src/kernel/compiler_new.dart

@@ -274,7 +274,9 @@ enum HotReloadBranchState {
 class LibraryCompiler extends ComputeOnceConstantVisitor<js_ast.Expression>
     with
         OnceConstantVisitorDefaultMixin<js_ast.Expression>,
+        StatementVisitorInternalNodeMixin<js_ast.Statement>,
         StatementVisitorExperimentExclusionMixin<js_ast.Statement>,
+        ExpressionVisitorInternalNodeMixin<js_ast.Expression>,
         ExpressionVisitorExperimentExclusionMixin<js_ast.Expression>
     implements
         StatementVisitor<js_ast.Statement>,
@@ -8550,36 +8552,6 @@ class LibraryCompiler extends ComputeOnceConstantVisitor<js_ast.Expression>
     return js_ast.Expression.binary(parts, '+');
   }
 
-  @override
-  js_ast.Expression visitListConcatenation(ListConcatenation node) {
-    // Only occurs inside unevaluated constants.
-    throw UnsupportedError('List concatenation');
-  }
-
-  @override
-  js_ast.Expression visitSetConcatenation(SetConcatenation node) {
-    // Only occurs inside unevaluated constants.
-    throw UnsupportedError('Set concatenation');
-  }
-
-  @override
-  js_ast.Expression visitMapConcatenation(MapConcatenation node) {
-    // Only occurs inside unevaluated constants.
-    throw UnsupportedError('Map concatenation');
-  }
-
-  @override
-  js_ast.Expression visitInstanceCreation(InstanceCreation node) {
-    // Only occurs inside unevaluated constants.
-    throw UnsupportedError('Instance creation');
-  }
-
-  @override
-  js_ast.Expression visitFileUriExpression(FileUriExpression node) {
-    // Only occurs inside unevaluated constants.
-    throw UnsupportedError('File URI expression');
-  }
-
   @override
   js_ast.Expression visitConstructorTearOff(ConstructorTearOff node) {
     throw UnsupportedError('Constructor tear off');
@@ -9472,43 +9444,6 @@ class LibraryCompiler extends ComputeOnceConstantVisitor<js_ast.Expression>
     return jsReceiver;
   }
 
-  @override
-  js_ast.Statement visitIfCaseStatement(IfCaseStatement node) {
-    // This node is internal to the front end and removed by the constant
-    // evaluator.
-    throw UnsupportedError('ProgramCompiler.visitIfCaseStatement');
-  }
-
-  @override
-  js_ast.Expression visitPatternAssignment(PatternAssignment node) {
-    // This node is internal to the front end and removed by the constant
-    // evaluator.
-    throw UnsupportedError('ProgramCompiler.visitPatternAssignment');
-  }
-
-  @override
-  js_ast.Statement visitPatternSwitchStatement(PatternSwitchStatement node) {
-    // This node is internal to the front end and removed by the constant
-    // evaluator.
-    throw UnsupportedError('ProgramCompiler.visitPatternSwitchStatement');
-  }
-
-  @override
-  js_ast.Statement visitPatternVariableDeclaration(
-    PatternVariableDeclaration node,
-  ) {
-    // This node is internal to the front end and removed by the constant
-    // evaluator.
-    throw UnsupportedError('ProgramCompiler.visitPatternVariableDeclaration');
-  }
-
-  @override
-  js_ast.Expression visitSwitchExpression(SwitchExpression node) {
-    // This node is internal to the front end and removed by the constant
-    // evaluator.
-    throw UnsupportedError('ProgramCompiler.visitSwitchExpression');
-  }
-
   @override
   js_ast.Expression visitAuxiliaryExpression(AuxiliaryExpression node) {
     throw UnsupportedError(

pkg/front_end/test/spell_checking_list_code.txt

@@ -454,6 +454,7 @@ delegating
 delim
 delimit
 delimiting
+delivered
 demands
 demangle
 demangled

pkg/kernel/lib/target/targets.dart

@@ -383,6 +383,16 @@ abstract class Target {
   /// literals (for const set literals).
   bool get supportsSetLiterals => true;
 
+  /// Whether [FileUriExpression] nodes are supported by this target after
+  /// constant evaluation.
+  ///
+  /// [FileUriExpression] are used internally in the CFE to handle annotations
+  /// on patches, and are replaced with [FileUriConstantExpression] nodes during
+  /// constant evaluation.
+  ///
+  /// Targets can opt in to using this node for general inlining.
+  bool get supportsFileUriExpression => false;
+
   /// Bit mask of [LateLowering] values for the late lowerings that should
   /// be performed by the CFE.
   ///

pkg/kernel/lib/verifier.dart

@@ -1794,6 +1794,116 @@ class VerifyingVisitor extends RecursiveResultVisitor<void> {
     }
     super.visitSwitchStatement(node);
   }
+
+  @override
+  void visitListConcatenation(ListConcatenation node) {
+    if (stage >= VerificationStage.afterConstantEvaluation) {
+      if (!inUnevaluatedConstant) {
+        problem(node, "Unexpected internal node $node.");
+      }
+    }
+  }
+
+  @override
+  void visitSetConcatenation(SetConcatenation node) {
+    if (stage >= VerificationStage.afterConstantEvaluation) {
+      if (!inUnevaluatedConstant) {
+        problem(node, "Unexpected internal node $node.");
+      }
+    }
+  }
+
+  @override
+  void visitMapConcatenation(MapConcatenation node) {
+    if (stage >= VerificationStage.afterConstantEvaluation) {
+      if (!inUnevaluatedConstant) {
+        problem(node, "Unexpected internal node $node.");
+      }
+    }
+  }
+
+  @override
+  void visitInstanceCreation(InstanceCreation node) {
+    if (stage >= VerificationStage.afterConstantEvaluation) {
+      if (!inUnevaluatedConstant) {
+        problem(node, "Unexpected internal node $node.");
+      }
+    }
+  }
+
+  @override
+  void visitFileUriExpression(FileUriExpression node) {
+    if (!target.supportsFileUriExpression) {
+      if (stage >= VerificationStage.afterConstantEvaluation) {
+        if (!inUnevaluatedConstant) {
+          problem(node, "Unexpected internal node $node.");
+        }
+      }
+    }
+  }
+
+  @override
+  void visitPatternAssignment(PatternAssignment node) {
+    if (stage >= VerificationStage.afterConstantEvaluation) {
+      problem(node, "Unexpected internal node $node.");
+    }
+  }
+
+  @override
+  void visitPatternVariableDeclaration(PatternVariableDeclaration node) {
+    if (stage >= VerificationStage.afterConstantEvaluation) {
+      problem(node, "Unexpected internal node $node.");
+    }
+  }
+
+  @override
+  void visitIfCaseStatement(IfCaseStatement node) {
+    if (stage >= VerificationStage.afterConstantEvaluation) {
+      problem(node, "Unexpected internal node $node.");
+    }
+  }
+
+  @override
+  void visitPatternSwitchStatement(PatternSwitchStatement node) {
+    if (stage >= VerificationStage.afterConstantEvaluation) {
+      problem(node, "Unexpected internal node $node.");
+    }
+  }
+
+  @override
+  void defaultPattern(Pattern node) {
+    if (stage >= VerificationStage.afterConstantEvaluation) {
+      problem(node, "Unexpected internal node $node.");
+    }
+  }
+
+  @override
+  void visitSwitchExpression(SwitchExpression node) {
+    if (stage >= VerificationStage.afterConstantEvaluation) {
+      problem(node, "Unexpected internal node $node.");
+    }
+  }
+
+  @override
+  void visitSwitchExpressionCase(SwitchExpressionCase node) {
+    if (stage >= VerificationStage.afterConstantEvaluation) {
+      problem(node, "Unexpected internal node $node.");
+    }
+  }
+
+  @override
+  void visitPatternGuard(PatternGuard node) {
+    if (stage >= VerificationStage.afterConstantEvaluation) {
+      problem(node, "Unexpected internal node $node.");
+    }
+  }
+
+  @override
+  void visitPatternSwitchCase(PatternSwitchCase node) {
+    if (stage >= VerificationStage.afterConstantEvaluation) {
+      problem(node, "Unexpected internal node $node.");
+    }
+  }
 }
 
 class VerifyGetStaticType extends RecursiveVisitor {