Skip to content

Commit c23ed7a

Browse files
alexmarkovCommit Queue
authored andcommitted
[lib/web_gl] Workaround to Flutter license script choking on web_gl_dart2js.dart
Flutter license script (which collects various licenses) processes only the first N number of bytes. Unfortunately, https://dart-review.googlesource.com/c/sdk/+/424741 increased size of the header in sdk/lib/web_gl/dart2js/web_gl_dart2js.dart so copyright notice in the middle of the file was cut in half and no longer recognized by the Flutter license script. Issue: flutter/flutter#168065 CoreLibraryReviewExempt: comment change Change-Id: I694066223b7fd4724c4856ce7875d64e870ab723 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425560 Commit-Queue: Srujan Gaddam <[email protected]> Reviewed-by: Srujan Gaddam <[email protected]> Auto-Submit: Alexander Markov <[email protected]>
1 parent a06be8f commit c23ed7a

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

sdk/lib/web_gl/dart2js/web_gl_dart2js.dart

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,11 @@ import 'dart:_js_helper'
2525
import 'dart:_foreign_helper' show JS;
2626
import 'dart:_interceptors' show JavaScriptObject, JSExtendableArray;
2727

28+
// This comment is an extra padding to work around Flutter license script
29+
// cutting a copyright notice in the middle of this file because it reads
30+
// only the first kMaxSize bytes of a file.
31+
// (https://github.com/flutter/flutter/issues/168065)
32+
2833
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2934
// for details. All rights reserved. Use of this source code is governed by a
3035
// BSD-style license that can be found in the LICENSE file.

tools/dom/templates/html/dart2js/web_gl_dart2js.darttemplate

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,4 +24,9 @@ import 'dart:_js_helper' show Creates, JSName, Native, Returns, convertDartClosu
2424
import 'dart:_foreign_helper' show JS;
2525
import 'dart:_interceptors' show JavaScriptObject, JSExtendableArray;
2626

27+
// This comment is an extra padding to work around Flutter license script
28+
// cutting a copyright notice in the middle of this file because it reads
29+
// only the first kMaxSize bytes of a file.
30+
// (https://github.com/flutter/flutter/issues/168065)
31+
2732
$!GENERATED_DART_FILES

0 commit comments

Comments
 (0)