Elements. Use getLinkingNode2(Fragment)

Change-Id: I977e38bca5bc6393747ab5e51061423fbc572c32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410880
Reviewed-by: Phil Quitslund <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/summary2/constructor_initializer_resolver.dart

@@ -39,7 +39,7 @@ class ConstructorInitializerResolver {
     if (element.isSynthetic) return;
 
     for (var fragment in element.fragments) {
-      var node = _linker.getLinkingNode(fragment);
+      var node = _linker.getLinkingNode2(fragment);
       if (node is! ConstructorDeclarationImpl) return;
 
       var constructorScope = LinkingNodeContext.get(node).scope;

pkg/analyzer/lib/src/summary2/default_types_builder.dart

@@ -274,7 +274,8 @@ class DefaultTypesBuilder {
         } else if (visited.add(startType.element3)) {
           void recurseParameters(List<TypeParameterElement2> parameters) {
             for (var parameter in parameters) {
-              var parameterNode = _linker.getLinkingNode2(parameter);
+              var parameterNode =
+                  _linker.getLinkingNode2(parameter.firstFragment);
               if (parameterNode is TypeParameter) {
                 var bound = parameterNode.bound;
                 if (bound != null) {

pkg/analyzer/lib/src/summary2/extension_type.dart

@@ -133,7 +133,7 @@ class _Node extends graph.Node<_Node> {
 
     var dependencies = <_Node>[];
     for (var element in visitor.dependencies) {
-      var declaration = walker.linker.getLinkingNode2(element);
+      var declaration = walker.linker.getLinkingNode2(element.firstFragment);
       if (declaration is ExtensionTypeDeclarationImpl) {
         var node = walker.getNode(declaration);
         dependencies.add(node);

pkg/analyzer/lib/src/summary2/link.dart

@@ -26,7 +26,6 @@ import 'package:analyzer/src/summary2/type_alias.dart';
 import 'package:analyzer/src/summary2/types_builder.dart';
 import 'package:analyzer/src/summary2/variance_builder.dart';
 import 'package:analyzer/src/util/performance/operation_performance.dart';
-import 'package:analyzer/src/utilities/extensions/element.dart';
 import 'package:analyzer/src/utilities/uri_cache.dart';
 
 LinkResult link({
@@ -80,15 +79,9 @@ class Linker {
     return elementNodes[element];
   }
 
-  /// If the [element] is part of a library being linked, return the node
-  /// from which it was created.
-  ast.AstNode? getLinkingNode2(Element2 element) {
-    return elementNodes[element.asElement];
-  }
-
   /// If the [fragment] is part of a library being linked, return the node
   /// from which it was created.
-  ast.AstNode? getLinkingNode3(Fragment fragment) {
+  ast.AstNode? getLinkingNode2(Fragment fragment) {
     return elementNodes[fragment];
   }
 

pkg/analyzer/lib/src/summary2/named_type_builder.dart

@@ -263,7 +263,7 @@ class NamedTypeBuilder extends TypeBuilder {
   }
 
   DartType _getAliasedType(TypeAliasElementImpl2 element) {
-    var typedefNode = linker.getLinkingNode2(element);
+    var typedefNode = linker.getLinkingNode2(element.firstFragment);
 
     // If the element is not being linked, the types have already been built.
     if (typedefNode == null) {

pkg/analyzer/lib/src/summary2/simply_bounded.dart

@@ -92,7 +92,7 @@ class SimplyBoundedDependencyWalker
   SimplyBoundedNode getNode(Element2 element) {
     var graphNode = nodeMap[element];
     if (graphNode == null) {
-      var node = linker.getLinkingNode2(element);
+      var node = linker.getLinkingNode2(element.firstFragment);
       if (node is ClassDeclaration) {
         var parameters = node.typeParameters?.typeParameters;
         graphNode = SimplyBoundedNode(

pkg/analyzer/lib/src/summary2/super_constructor_resolver.dart

@@ -39,7 +39,7 @@ class SuperConstructorResolver {
 
     var invokesDefaultSuperConstructor = true;
     for (var fragment in element.fragments) {
-      var node = _linker.getLinkingNode3(fragment);
+      var node = _linker.getLinkingNode2(fragment);
       if (node is ConstructorDeclaration) {
         for (var initializer in node.initializers) {
           if (initializer is RedirectingConstructorInvocation) {

pkg/analyzer/lib/src/summary2/type_alias.dart

@@ -92,7 +92,7 @@ class _Finder {
         return;
       }
 
-      var typeNode = linker.getLinkingNode2(element);
+      var typeNode = linker.getLinkingNode2(element.firstFragment);
       if (typeNode != null) {
         if (typeNode == self) {
           hasSelfReference = true;

pkg/analyzer/lib/src/summary2/variance_builder.dart

@@ -229,7 +229,7 @@ class VarianceBuilder {
   }
 
   void _typeAliasElement(TypeAliasElementImpl2 element) {
-    var node = _linker.getLinkingNode2(element);
+    var node = _linker.getLinkingNode2(element.firstFragment);
     if (node == null) {
       // Not linking.
     } else if (node is GenericTypeAliasImpl) {