Remove babel from DEPS and (dart2js) IE support from test infra.

Tested: N/A
Change-Id: Ib1804b49c40cac9be52e732090e8160444ebb48d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/417948
Commit-Queue: Mayank Patke <[email protected]>
Reviewed-by: Alexander Thomas <[email protected]>
Reviewed-by: Bob Nystrom <[email protected]>
Reviewed-by: Sigmund Cherem <[email protected]>

Author: fishythefish

DEPS

@@ -260,13 +260,6 @@ deps = {
   Var("dart_root") + "/third_party/markupsafe":
       Var("chromium_git") + "/chromium/src/third_party/markupsafe.git" +
       "@" + Var("markupsafe_rev"),
-  Var("dart_root") + "/third_party/babel": {
-      "packages": [{
-          "package": "dart/third_party/babel",
-          "version": "version:7.4.5",
-      }],
-      "dep_type": "cipd",
-  },
   Var("dart_root") + "/third_party/zlib":
       Var("chromium_git") + "/chromium/src/third_party/zlib.git" +
       "@" + Var("zlib_rev"),

docs/Building.md

@@ -158,9 +158,9 @@ All tests are executed using the `test.py` script under `tools/`.  You need to u
 $ ./tools/build.py --mode release --arch ia32 most run_ffi_unit_tests
 ```
 
-Now you can run all tests as follows (Safari, Firefox, Chrome, and IE must be installed, if you want to run the tests on them):
+Now you can run all tests as follows (Safari, Firefox, and Chrome must be installed, if you want to run the tests on them):
 ```bash
-$ ./tools/test.py -mrelease --arch=ia32 --compiler=dartk,dart2js --runtime=vm,d8,chrome,firefox,[safari,ie10]
+$ ./tools/test.py -mrelease --arch=ia32 --compiler=dartk,dart2js --runtime=vm,d8,chrome,firefox,[safari]
 ```
 Specify the compiler used (optional -- only necessary if you are compiling to JavaScript (required for most browsers), the default is "none") and a runtime (where the code will be run).
 

docs/Status-files.md

@@ -13,7 +13,7 @@ and runtimes we maintain and support.
 We have tens of thousands of tests and a single test may be run across a
 combinatorial explosion of configurations. Does the static analyzer report any
 errors on it? In strong mode? Does it run on the standalone VM? Can dart2js
-compile it? Does the resulting code run in Chrome? Firefox? IE? In checked mode?
+compile it? Does the resulting code run in Chrome? Firefox? In checked mode?
 With minification on? You get the idea.
 
 Many tests are only meaningful for certain combinations of configurations. A

pkg/smith/lib/configuration.dart

@@ -282,7 +282,6 @@ class Configuration {
         name, architecture, compiler, mode, runtime, system,
         nnbdMode: nnbdMode,
         sanitizer: sanitizer,
-        babel: stringOption("babel"),
         builderTag: stringOption("builder-tag"),
         genKernelOptions: stringListOption("gen-kernel-options"),
         vmOptions: stringListOption("vm-options"),
@@ -329,8 +328,6 @@ class Configuration {
 
   final Sanitizer sanitizer;
 
-  final String babel;
-
   final String builderTag;
 
   final List<String> genKernelOptions;
@@ -385,7 +382,6 @@ class Configuration {
       this.runtime, this.system,
       {NnbdMode? nnbdMode,
       Sanitizer? sanitizer,
-      String? babel,
       String? builderTag,
       List<String>? genKernelOptions,
       List<String>? vmOptions,
@@ -408,7 +404,6 @@ class Configuration {
       bool? useQemu})
       : nnbdMode = nnbdMode ?? NnbdMode.strong,
         sanitizer = sanitizer ?? Sanitizer.none,
-        babel = babel ?? "",
         builderTag = builderTag ?? "",
         genKernelOptions = genKernelOptions ?? <String>[],
         vmOptions = vmOptions ?? <String>[],
@@ -448,7 +443,6 @@ class Configuration {
     this.system, {
     required this.nnbdMode,
     required this.sanitizer,
-    required this.babel,
     required this.builderTag,
     required this.genKernelOptions,
     required this.vmOptions,
@@ -486,7 +480,6 @@ class Configuration {
         System.host,
         nnbdMode: source.nnbdMode,
         sanitizer: source.sanitizer,
-        babel: source.babel,
         builderTag: source.builderTag,
         genKernelOptions: source.genKernelOptions,
         vmOptions: source.vmOptions,
@@ -523,7 +516,6 @@ class Configuration {
       system == other.system &&
       nnbdMode == other.nnbdMode &&
       sanitizer == other.sanitizer &&
-      babel == other.babel &&
       builderTag == other.builderTag &&
       _listsEqual(genKernelOptions, other.genKernelOptions) &&
       _listsEqual(vmOptions, other.vmOptions) &&
@@ -575,7 +567,6 @@ class Configuration {
       runtime.hashCode ^
       system.hashCode ^
       nnbdMode.hashCode ^
-      babel.hashCode ^
       builderTag.hashCode ^
       genKernelOptions.join(" & ").hashCode ^
       vmOptions.join(" & ").hashCode ^
@@ -619,7 +610,6 @@ class Configuration {
       fields.add("$name: [${field.join(", ")}]");
     }
 
-    if (babel.isNotEmpty) fields.add("babel: $babel");
     if (builderTag.isNotEmpty) fields.add("builder-tag: $builderTag");
     stringListField("gen-kernel-options", genKernelOptions);
     stringListField("vm-options", vmOptions);
@@ -676,7 +666,6 @@ class Configuration {
 
     fields.add("nnbd: $nnbdMode ${other.nnbdMode}");
     fields.add("sanitizer: $sanitizer ${other.sanitizer}");
-    stringField("babel", babel, other.babel);
     stringField("builder-tag", builderTag, other.builderTag);
     stringListField(
         "gen-kernel-options", genKernelOptions, other.genKernelOptions);
@@ -865,9 +854,6 @@ class Compiler extends NamedEnum {
           Runtime.firefox,
           Runtime.chrome,
           Runtime.safari,
-          Runtime.ie9,
-          Runtime.ie10,
-          Runtime.ie11,
           Runtime.edge,
           Runtime.chromeOnAndroid,
         ];
@@ -1007,9 +993,6 @@ class Runtime extends NamedEnum {
   static const firefox = Runtime._('firefox');
   static const chrome = Runtime._('chrome');
   static const safari = Runtime._('safari');
-  static const ie9 = Runtime._('ie9');
-  static const ie10 = Runtime._('ie10');
-  static const ie11 = Runtime._('ie11');
   static const edge = Runtime._('edge');
   static const chromeOnAndroid = Runtime._('chromeOnAndroid');
   static const none = Runtime._('none');
@@ -1026,9 +1009,6 @@ class Runtime extends NamedEnum {
     firefox,
     chrome,
     safari,
-    ie9,
-    ie10,
-    ie11,
     edge,
     chromeOnAndroid,
     none
@@ -1043,27 +1023,14 @@ class Runtime extends NamedEnum {
 
   const Runtime._(super.name);
 
-  bool get isBrowser => const [
-        ie9,
-        ie10,
-        ie11,
-        edge,
-        safari,
-        chrome,
-        firefox,
-        chromeOnAndroid
-      ].contains(this);
-
-  bool get isIE => name.startsWith("ie");
+  bool get isBrowser =>
+      const [edge, safari, chrome, firefox, chromeOnAndroid].contains(this);
 
   bool get isSafari => name.startsWith("safari");
 
   /// Whether this runtime is a command-line JavaScript environment.
   bool get isJSCommandLine => const [d8, jsc, jsshell].contains(this);
 
-  /// If the runtime doesn't support `Window.open`, we use iframes instead.
-  bool get requiresIFrame => !const [ie11, ie10].contains(this);
-
   /// The preferred compiler to use with this runtime if no other compiler is
   /// specified.
   Compiler get defaultCompiler {
@@ -1080,9 +1047,6 @@ class Runtime extends NamedEnum {
       case firefox:
       case chrome:
       case safari:
-      case ie9:
-      case ie10:
-      case ie11:
       case edge:
       case chromeOnAndroid:
         return Compiler.dart2js;