[analyzer] Dot Shorthands: Change DotShorthandPropertyAccess Token to SimpleIdentifier.

This CL changes `propertyName` to be a `SimpleIdentifier` instead of `Token` because we need to resolve and store the resolved element in the `SimpleIdentifier`.

Note that the corresponding class `PropertyAccess` represents its
`propertyName` as a `SimpleIdentifier` for the same reason.

Bug: #59835
Change-Id: I934f66f914b061b8593399c79a0f7b590b84cc12
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419584
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Kallen Tu <[email protected]>
Reviewed-by: Paul Berry <[email protected]>

Author: kallentu

pkg/analyzer/api.txt

@@ -740,7 +740,7 @@ package:analyzer/dart/ast/ast.dart:
     period (getter: Token)
   DotShorthandPropertyAccess (class extends Expression, experimental):
     period (getter: Token)
-    propertyName (getter: Token)
+    propertyName (getter: SimpleIdentifier)
   DottedName (class extends Object implements AstNode):
     components (getter: NodeList<SimpleIdentifier>)
   DoubleLiteral (class extends Object implements Literal):

pkg/analyzer/lib/src/dart/ast/ast.dart

@@ -5479,36 +5479,44 @@ abstract final class DotShorthandPropertyAccess extends Expression {
   Token get period;
 
   /// The name of the property being accessed.
-  Token get propertyName;
+  SimpleIdentifier get propertyName;
 }
 
 final class DotShorthandPropertyAccessImpl extends ExpressionImpl
     implements DotShorthandPropertyAccess {
   @override
   final Token period;
 
-  @override
-  final Token propertyName;
+  SimpleIdentifierImpl _propertyName;
 
   /// Initializes a newly created dot shorthand property access.
   DotShorthandPropertyAccessImpl({
     required this.period,
-    required this.propertyName,
-  });
+    required SimpleIdentifierImpl propertyName,
+  }) : _propertyName = propertyName {
+    _becomeParentOf(_propertyName);
+  }
 
   @override
   Token get beginToken => period;
 
   @override
-  Token get endToken => propertyName;
+  Token get endToken => propertyName.endToken;
 
   @override
   Precedence get precedence => Precedence.postfix;
 
+  @override
+  SimpleIdentifierImpl get propertyName => _propertyName;
+
+  set propertyName(SimpleIdentifierImpl identifier) {
+    _propertyName = _becomeParentOf(identifier);
+  }
+
   @override
   ChildEntities get _childEntities => ChildEntities()
     ..addToken('period', period)
-    ..addToken('propertyName', propertyName);
+    ..addNode('propertyName', propertyName);
 
   @override
   E? accept<E>(AstVisitor<E> visitor) =>
@@ -5520,7 +5528,9 @@ final class DotShorthandPropertyAccessImpl extends ExpressionImpl
   }
 
   @override
-  void visitChildren(AstVisitor visitor) {}
+  void visitChildren(AstVisitor visitor) {
+    propertyName.accept(visitor);
+  }
 }
 
 /// A dotted name, used in a configuration within an import or export directive.

pkg/analyzer/lib/src/dart/ast/to_source_visitor.dart

@@ -359,7 +359,7 @@ class ToSourceVisitor implements AstVisitor<void> {
   @override
   void visitDotShorthandPropertyAccess(DotShorthandPropertyAccess node) {
     _visitToken(node.period);
-    _visitToken(node.propertyName);
+    _visitNode(node.propertyName);
   }
 
   @override

pkg/analyzer/lib/src/dart/ast/utilities.dart

@@ -725,8 +725,13 @@ class NodeReplacer extends ThrowingAstVisitor<bool> {
 
   @override
   bool? visitDotShorthandPropertyAccess(
-          covariant DotShorthandPropertyAccessImpl node) =>
-      visitNode(node);
+      covariant DotShorthandPropertyAccessImpl node) {
+    if (identical(node.propertyName, _oldNode)) {
+      node.propertyName = _newNode as SimpleIdentifierImpl;
+      return true;
+    }
+    return visitNode(node);
+  }
 
   @override
   bool visitDottedName(covariant DottedNameImpl node) {