[analyzer] Collect enabled experiments in experimentsForTests

This CL removes the unnecessary overrides of the `experiments` getter
from the tests and collects the corresponding experiment flags added to
the returned value of the getter in the individual tests to the
'experimentsForTests' list that is used by all tests. Specifically, the
experiments `variance` is enabled for all tests.

The flag `inference_update_1` is removed from the experiments list,
since it's enabled by default. In the tests that explicitly require a
distinction between the flag being enabled and disabled, the getter
`_isEnabled` is overridden and returns a value corresponding to the
test.

The flag `inference_update_4` still appears in one of the overrides of
the `experiments` getter, since enabling it in all tests appears
breaking.

This is a follow-up to
https://dart-review.googlesource.com/c/sdk/+/430720/comment/4c3f016e_4933f925/

Change-Id: I4d35e3c6259e2f7e6751d180b5790c13f68de1ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/434360
Reviewed-by: Konstantin Shcheglov <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>

Author: chloestefantsova

pkg/analyzer/test/src/dart/resolution/assignment_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import 'package:analyzer/dart/analysis/features.dart';
 import 'package:analyzer/src/dart/error/syntactic_errors.dart';
 import 'package:analyzer/src/error/codes.dart';
 import 'package:test_reflective_loader/test_reflective_loader.dart';
@@ -5388,11 +5387,6 @@ AssignmentExpression
 
 @reflectiveTest
 class InferenceUpdate3Test extends PubPackageResolutionTest {
-  @override
-  List<String> get experiments {
-    return [...super.experiments, Feature.inference_update_3.enableString];
-  }
-
   test_ifNull_contextIsConvertedToATypeUsingGreatestClosure() async {
     await assertNoErrorsInCode('''
 class A {}

pkg/analyzer/test/src/dart/resolution/binary_expression_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import 'package:analyzer/dart/analysis/features.dart';
 import 'package:analyzer/src/dart/error/syntactic_errors.dart';
 import 'package:analyzer/src/error/codes.dart';
 import 'package:test_reflective_loader/test_reflective_loader.dart';
@@ -2264,11 +2263,6 @@ BinaryExpression
 
 @reflectiveTest
 class InferenceUpdate3Test extends PubPackageResolutionTest {
-  @override
-  List<String> get experiments {
-    return [...super.experiments, Feature.inference_update_3.enableString];
-  }
-
   test_ifNull_contextIsConvertedToATypeUsingGreatestClosure() async {
     await assertNoErrorsInCode('''
 class A {}

pkg/analyzer/test/src/dart/resolution/conditional_expression_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import 'package:analyzer/dart/analysis/features.dart';
 import 'package:analyzer/src/dart/error/syntactic_errors.dart';
 import 'package:analyzer/src/error/codes.dart';
 import 'package:test_reflective_loader/test_reflective_loader.dart';
@@ -330,11 +329,6 @@ void f(bool a, int b, int c) {
 
 @reflectiveTest
 class InferenceUpdate3Test extends PubPackageResolutionTest {
-  @override
-  List<String> get experiments {
-    return [...super.experiments, Feature.inference_update_3.enableString];
-  }
-
   test_contextIsConvertedToATypeUsingGreatestClosure() async {
     await assertNoErrorsInCode('''
 class A {}

pkg/analyzer/test/src/dart/resolution/generic_type_alias_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import 'package:analyzer/dart/analysis/features.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/src/dart/error/syntactic_errors.dart';
 import 'package:analyzer/src/error/codes.dart';
@@ -107,11 +106,6 @@ C<G>? x;
 class GenericTypeAliasResolutionTest_WithoutGenericMetadata
     extends PubPackageResolutionTest
     with GenericTypeAliasResolutionTestCases {
-  @override
-  List<String> get experiments {
-    return [...super.experiments, Feature.generic_metadata.enableString];
-  }
-
   test_genericFunctionTypeCannotBeTypeArgument_def_class() async {
     await assertErrorsInCode(
       r'''

pkg/analyzer/test/src/dart/resolution/postfix_expression_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import 'package:analyzer/dart/analysis/features.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/src/dart/error/syntactic_errors.dart';
 import 'package:analyzer/src/error/codes.dart';
@@ -19,11 +18,6 @@ main() {
 
 @reflectiveTest
 class InferenceUpdate4Test extends PubPackageResolutionTest {
-  @override
-  List<String> get experiments {
-    return [...super.experiments, Feature.inference_update_4.enableString];
-  }
-
   test_isExpression_notPromoted() async {
     await assertNoErrorsInCode('''
 f() {

pkg/analyzer/test/src/dart/resolution/type_inference/inference_update_1_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import 'package:analyzer/dart/analysis/features.dart';
 import 'package:analyzer/src/error/codes.dart';
 import 'package:test/test.dart';
 import 'package:test_reflective_loader/test_reflective_loader.dart';
@@ -21,15 +20,16 @@ class HorizontalInferenceDisabledTest extends PubPackageResolutionTest
     with HorizontalInferenceTestCases {
   @override
   String get testPackageLanguageVersion => '2.17';
+
+  @override
+  bool get _isEnabled => false;
 }
 
 @reflectiveTest
 class HorizontalInferenceEnabledTest extends PubPackageResolutionTest
     with HorizontalInferenceTestCases {
   @override
-  List<String> get experiments {
-    return [...super.experiments, Feature.inference_update_1.enableString];
-  }
+  bool get _isEnabled => true;
 
   test_record_field_named() async {
     // A round of horizontal inference should occur between the first argument
@@ -61,8 +61,7 @@ test() {
 }
 
 mixin HorizontalInferenceTestCases on PubPackageResolutionTest {
-  bool get _isEnabled =>
-      experiments.contains(Feature.inference_update_1.enableString);
+  bool get _isEnabled;
 
   test_closure_passed_to_dynamic() async {
     await assertNoErrorsInCode('''

pkg/analyzer/test/src/dart/resolution/variance_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import 'package:analyzer/dart/analysis/features.dart';
 import 'package:analyzer/src/error/codes.dart';
 import 'package:test_reflective_loader/test_reflective_loader.dart';
 
@@ -16,11 +15,6 @@ main() {
 
 @reflectiveTest
 class VarianceResolutionTest extends PubPackageResolutionTest {
-  @override
-  List<String> get experiments {
-    return [...super.experiments, Feature.variance.enableString];
-  }
-
   test_inference_in_parameter() async {
     await assertNoErrorsInCode('''
 class Contravariant<in T> {}

pkg/analyzer/test/src/diagnostics/generic_function_type_cannot_be_bound_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import 'package:analyzer/dart/analysis/features.dart';
 import 'package:analyzer/src/error/codes.dart';
 import 'package:test_reflective_loader/test_reflective_loader.dart';
 
@@ -74,11 +73,6 @@ typedef T foo<T extends S Function<S>(S)>(T t);
 @reflectiveTest
 class GenericFunctionTypeCannotBeBoundWithoutGenericMetadataTest
     extends PubPackageResolutionTest {
-  @override
-  List<String> get experiments {
-    return [...super.experiments, Feature.generic_metadata.enableString];
-  }
-
   test_class() async {
     await assertErrorsInCode(
       r'''

pkg/analyzer/test/src/diagnostics/getter_not_subtype_setter_types_test.dart

@@ -4,7 +4,6 @@
 
 import 'package:analyzer/dart/analysis/features.dart';
 import 'package:analyzer/src/error/codes.dart';
-import 'package:analyzer_testing/experiments/experiments.dart';
 import 'package:collection/collection.dart';
 import 'package:test_reflective_loader/test_reflective_loader.dart';
 
@@ -28,10 +27,7 @@ class GetterNotSubtypeSetterTypesTest_withGetterSetterErrorFeature
 
 @reflectiveTest
 class GetterNotSubtypeSetterTypesTest_withoutGetterSetterErrorFeature
-    extends _GetterNotSubtypeSetterTypesTest {
-  @override
-  List<String> get experiments => [...experimentsForTests];
-}
+    extends _GetterNotSubtypeSetterTypesTest {}
 
 class _GetterNotSubtypeSetterTypesTest extends PubPackageResolutionTest {
   test_class_instance() async {

pkg/analyzer/test/src/diagnostics/redeclare_on_non_redeclaring_member_test.dart

@@ -16,9 +16,6 @@ main() {
 
 @reflectiveTest
 class RedeclareOnNonRedeclaringMemberTest extends PubPackageResolutionTest {
-  @override
-  List<String> get experiments => [];
-
   @override
   void setUp() {
     super.setUp();