Fine. Remove _InstanceItemMemberItemKind and related.

Change-Id: I5c3e4912c87e034edc4c5fa412873047998e95ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/448721
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/dart/analysis/driver.dart

@@ -106,7 +106,7 @@ testFineAfterLibraryAnalyzerHook;
 // TODO(scheglov): Clean up the list of implicitly analyzed files.
 class AnalysisDriver {
   /// The version of data format, should be incremented on every format change.
-  static const int DATA_VERSION = 543;
+  static const int DATA_VERSION = 544;
 
   /// The number of exception contexts allowed to write. Once this field is
   /// zero, we stop writing any new exception contexts in this process.

pkg/analyzer/lib/src/fine/manifest_item.dart

@@ -689,11 +689,6 @@ class InstanceItemFieldItem extends InstanceItemMemberItem<FieldElementImpl> {
     constInitializer.writeOptional(sink);
   }
 
-  @override
-  void writeKind(BufferedSink sink) {
-    sink.writeEnum(_InstanceItemMemberItemKind.field);
-  }
-
   static Map<LookupName, InstanceItemFieldItem> readMap(
     SummaryDataReader reader,
   ) {
@@ -754,11 +749,6 @@ class InstanceItemGetterItem extends InstanceItemMemberItem<GetterElementImpl> {
     returnType.write(sink);
   }
 
-  @override
-  void writeKind(BufferedSink sink) {
-    sink.writeEnum(_InstanceItemMemberItemKind.getter);
-  }
-
   static Map<LookupName, InstanceItemGetterItem> readMap(
     SummaryDataReader reader,
   ) {
@@ -805,29 +795,6 @@ sealed class InstanceItemMemberItem<E extends ElementImpl>
     super.write(sink);
     sink.writeBool(isStatic);
   }
-
-  void writeKind(BufferedSink sink);
-
-  void writeWithKind(BufferedSink sink) {
-    writeKind(sink);
-    write(sink);
-  }
-
-  static InstanceItemMemberItem<ElementImpl> read(SummaryDataReader reader) {
-    var kind = reader.readEnum(_InstanceItemMemberItemKind.values);
-    switch (kind) {
-      case _InstanceItemMemberItemKind.field:
-        return InstanceItemFieldItem.read(reader);
-      case _InstanceItemMemberItemKind.getter:
-        return InstanceItemGetterItem.read(reader);
-      case _InstanceItemMemberItemKind.method:
-        return InstanceItemMethodItem.read(reader);
-      case _InstanceItemMemberItemKind.setter:
-        return InstanceItemSetterItem.read(reader);
-      case _InstanceItemMemberItemKind.constructor:
-        return InterfaceItemConstructorItem.read(reader);
-    }
-  }
 }
 
 class InstanceItemMethodItem extends InstanceItemMemberItem<MethodElementImpl> {
@@ -877,11 +844,6 @@ class InstanceItemMethodItem extends InstanceItemMemberItem<MethodElementImpl> {
     functionType.writeNoTag(sink);
   }
 
-  @override
-  void writeKind(BufferedSink sink) {
-    sink.writeEnum(_InstanceItemMemberItemKind.method);
-  }
-
   static Map<LookupName, InstanceItemMethodItem> readMap(
     SummaryDataReader reader,
   ) {
@@ -942,11 +904,6 @@ class InstanceItemSetterItem extends InstanceItemMemberItem<SetterElementImpl> {
     functionType.writeNoTag(sink);
   }
 
-  @override
-  void writeKind(BufferedSink sink) {
-    sink.writeEnum(_InstanceItemMemberItemKind.setter);
-  }
-
   static Map<LookupName, InstanceItemSetterItem> readMap(
     SummaryDataReader reader,
   ) {
@@ -1095,11 +1052,6 @@ class InterfaceItemConstructorItem
     constantInitializers.writeList(sink);
   }
 
-  @override
-  void writeKind(BufferedSink sink) {
-    sink.writeEnum(_InstanceItemMemberItemKind.constructor);
-  }
-
   static Map<LookupName, InterfaceItemConstructorItem> readMap(
     SummaryDataReader reader,
   ) {
@@ -1708,8 +1660,6 @@ class TypeAliasItem extends TopLevelItem<TypeAliasElementImpl> {
   }
 }
 
-enum _InstanceItemMemberItemKind { field, constructor, method, getter, setter }
-
 extension LookupNameToIdMapExtension on Map<LookupName, ManifestItemId> {
   void write(BufferedSink sink) {
     sink.writeMap(